aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMateusz Guzik <mjg@FreeBSD.org>2021-10-19 11:57:47 +0000
committerKristof Provost <kp@FreeBSD.org>2023-06-30 07:06:44 +0000
commit0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae (patch)
treebc6e20581d556feda03310c85fbb7432be5bc382
parent0f287f6a96cacda32ee17447987add3e05aa5fc6 (diff)
downloadsrc-0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae.tar.gz
src-0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae.zip
pf: fix some cc --analyze warnings
Reviewed by: kp Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit bcd4c17ccaacf995224882dc1d05e2a51867bdf2)
-rw-r--r--sys/netpfil/pf/if_pfsync.c2
-rw-r--r--sys/netpfil/pf/pf_ioctl.c2
-rw-r--r--sys/netpfil/pf/pf_norm.c2
3 files changed, 3 insertions, 3 deletions
diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c
index b05e1ae9550a..9cf1071b3248 100644
--- a/sys/netpfil/pf/if_pfsync.c
+++ b/sys/netpfil/pf/if_pfsync.c
@@ -2545,7 +2545,7 @@ VNET_SYSINIT(vnet_pfsync_init, SI_SUB_PROTO_FIREWALL, SI_ORDER_ANY,
static void
vnet_pfsync_uninit(const void *unused __unused)
{
- int ret;
+ int ret __diagused;
pfsync_pointers_uninit();
diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c
index 00021655605b..07463ecbbcf3 100644
--- a/sys/netpfil/pf/pf_ioctl.c
+++ b/sys/netpfil/pf/pf_ioctl.c
@@ -5639,7 +5639,7 @@ hook_pf(void)
{
struct pfil_hook_args pha;
struct pfil_link_args pla;
- int ret;
+ int ret __diagused;
if (V_pf_pfil_hooked)
return;
diff --git a/sys/netpfil/pf/pf_norm.c b/sys/netpfil/pf/pf_norm.c
index 56b30faf7e52..cac9c1fe391f 100644
--- a/sys/netpfil/pf/pf_norm.c
+++ b/sys/netpfil/pf/pf_norm.c
@@ -1002,7 +1002,7 @@ pf_refragment6(struct ifnet *ifp, struct mbuf **m0, struct m_tag *mtag)
DPFPRINTF(("refragment error %d\n", error));
action = PF_DROP;
}
- for (t = m; m; m = t) {
+ for (; m; m = t) {
t = m->m_nextpkt;
m->m_nextpkt = NULL;
m->m_flags |= M_SKIP_FIREWALL;