diff options
author | John Baldwin <jhb@FreeBSD.org> | 2021-09-14 20:46:14 +0000 |
---|---|---|
committer | John Baldwin <jhb@FreeBSD.org> | 2021-09-14 20:46:14 +0000 |
commit | 1ecbc1d8e9d3fbcd8e68fc68f0a32944a12ddb1e (patch) | |
tree | 5ec999ce9a01c9a3d591a17278c1b29899bea013 | |
parent | bdf0f24bb16d556a5b1e01cdfc087d08e91ac572 (diff) | |
download | src-1ecbc1d8e9d3fbcd8e68fc68f0a32944a12ddb1e.tar.gz src-1ecbc1d8e9d3fbcd8e68fc68f0a32944a12ddb1e.zip |
cxgbe tom: Don't queue AIO requests on listen sockets.
This is similar to the fixes in 141fe2dceeae. One difference is that
TOE sockets do not change states (listen vs non-listen) once created,
so no lock is needed for SOLISTENING().
Sponsored by: Chelsio Communications
-rw-r--r-- | sys/dev/cxgbe/tom/t4_tom.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/sys/dev/cxgbe/tom/t4_tom.c b/sys/dev/cxgbe/tom/t4_tom.c index a444f0c9d690..41f55fdbd426 100644 --- a/sys/dev/cxgbe/tom/t4_tom.c +++ b/sys/dev/cxgbe/tom/t4_tom.c @@ -1989,6 +1989,13 @@ t4_aio_queue_tom(struct socket *so, struct kaiocb *job) struct toepcb *toep = tp->t_toe; int error; + /* + * No lock is needed as TOE sockets never change between + * active and passive. + */ + if (SOLISTENING(so)) + return (EINVAL); + if (ulp_mode(toep) == ULP_MODE_TCPDDP) { error = t4_aio_queue_ddp(so, job); if (error != EOPNOTSUPP) |