diff options
| author | Kristof Provost <kp@FreeBSD.org> | 2023-11-29 18:06:31 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2023-12-05 18:31:14 +0000 |
| commit | 1f8724dd18b0d57ccc74086040411bb1f0059be0 (patch) | |
| tree | e758c605481242b53233e02c0bde4034cd33d77a | |
| parent | 7f1c8b021bfe060e14e176ef7af3f2259ac6f78a (diff) | |
| download | src-1f8724dd18b0d57ccc74086040411bb1f0059be0.tar.gz src-1f8724dd18b0d57ccc74086040411bb1f0059be0.zip | |
pf: remove incorrect fragmentation check
We do not need to check PFDESC_IP_REAS while tracking TCP state.
Moreover, this check incorrectly considers no-data packets (e.g. RST) to
be in-window when this flag is not set.
Sponsored by: Rubicon Communications, LLC ("Netgate")
Approved by: so
Security: FreeBSD-SA-23:17.pf
(cherry picked from commit 6284d5f76d6bd2d97fe287c5adabf59c79688eda)
(cherry picked from commit 0415f0554b72b93a1986292d28f679594f6ce6a6)
| -rw-r--r-- | sys/netpfil/pf/pf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index dd4c49959a60..cd3403b1bd22 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -4477,8 +4477,7 @@ pf_tcp_track_full(struct pf_kstate **state, struct pfi_kkif *kif, (ackskew <= (MAXACKWINDOW << sws)) && /* Acking not more than one window forward */ ((th->th_flags & TH_RST) == 0 || orig_seq == src->seqlo || - (orig_seq == src->seqlo + 1) || (orig_seq + 1 == src->seqlo) || - (pd->flags & PFDESC_IP_REAS) == 0)) { + (orig_seq == src->seqlo + 1) || (orig_seq + 1 == src->seqlo))) { /* Require an exact/+1 sequence match on resets when possible */ if (dst->scrub || src->scrub) { |