diff options
| author | Kristof Provost <kp@FreeBSD.org> | 2021-03-10 14:50:42 +0000 |
|---|---|---|
| committer | Kristof Provost <kp@FreeBSD.org> | 2021-03-19 22:39:39 +0000 |
| commit | 2001c1a0d2c003379c702373a9d259cb660cbff3 (patch) | |
| tree | 7471937c3ee7fabf3203101e6de2b7ad7790ae5c | |
| parent | bc98489262fb1600208ce87ccefa41f6c8cb9f9b (diff) | |
| download | src-2001c1a0d2c003379c702373a9d259cb660cbff3.tar.gz src-2001c1a0d2c003379c702373a9d259cb660cbff3.zip | |
pf: Remove redundant kif != NULL checks
pf_kkif_free() already checks for NULL, so we don't have to check before
we call it.
Reviewed by: melifaro@
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D29195
(cherry picked from commit 913e7dc3e0eb7df78ec0e7ecc7dd160a316a3ac6)
| -rw-r--r-- | sys/netpfil/pf/pf_ioctl.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c index 5f9eb771d0e0..977f0debacaa 100644 --- a/sys/netpfil/pf/pf_ioctl.c +++ b/sys/netpfil/pf/pf_ioctl.c @@ -2001,8 +2001,7 @@ pfioctl(struct cdev *dev, u_long cmd, caddr_t addr, int flags, struct thread *td DIOCADDRULE_error: PF_RULES_WUNLOCK(); pf_krule_free(rule); - if (kif) - pf_kkif_free(kif); + pf_kkif_free(kif); break; } @@ -2300,8 +2299,7 @@ DIOCADDRULE_error: DIOCCHANGERULE_error: PF_RULES_WUNLOCK(); pf_krule_free(newrule); - if (kif != NULL) - pf_kkif_free(kif); + pf_kkif_free(kif); break; } @@ -3144,8 +3142,7 @@ DIOCCHANGEADDR_error: free(newpa, M_PFRULE); } PF_RULES_WUNLOCK(); - if (kif != NULL) - pf_kkif_free(kif); + pf_kkif_free(kif); break; } |