diff options
author | Hans Petter Selasky <hselasky@FreeBSD.org> | 2022-05-19 08:10:48 +0000 |
---|---|---|
committer | Hans Petter Selasky <hselasky@FreeBSD.org> | 2022-06-07 06:44:28 +0000 |
commit | 267e6442d049939cd9c8ab5e3b0134deace39e66 (patch) | |
tree | 4b3ee72d8b21adbb9fff362642ab5d13ddd14fc1 | |
parent | 6953b4870f00e4d2ef99ae561ae03da028cb21e6 (diff) | |
download | src-267e6442d049939cd9c8ab5e3b0134deace39e66.tar.gz src-267e6442d049939cd9c8ab5e3b0134deace39e66.zip |
mlx4: Fix a memory leak bug.
In function mlx4_opreq_action(), pointer "mailbox" is not released,
when mlx4_cmd_box() return and error, causing a memory leak bug.
Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can
free this pointer.
Linux commit:
febfd9d3c7f74063e8e630b15413ca91b567f963
PR: 264056
Sponsored by: NVIDIA Networking
(cherry picked from commit 527762b2f776381569bd662ce236d2845234c0a7)
-rw-r--r-- | sys/dev/mlx4/mlx4_core/mlx4_fw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/mlx4/mlx4_core/mlx4_fw.c b/sys/dev/mlx4/mlx4_core/mlx4_fw.c index 68aa7e76c79d..de83a3bf5a76 100644 --- a/sys/dev/mlx4/mlx4_core/mlx4_fw.c +++ b/sys/dev/mlx4/mlx4_core/mlx4_fw.c @@ -2702,7 +2702,7 @@ void mlx4_opreq_action(struct work_struct *work) if (err) { mlx4_err(dev, "Failed to retrieve required operation: %d\n", err); - return; + goto out; } MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET); MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET); |