aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Stone <rstone@FreeBSD.org>2021-07-07 20:04:10 +0000
committerRyan Stone <rstone@FreeBSD.org>2021-08-31 02:59:33 +0000
commit315bca194a14f3b9ec683675bafa8d990d16bfaf (patch)
tree25aa3c4ceff4e19cd30e999e127208d11fc7d1a0
parent9939af1a161e5c219ece5e7c5bc02dcb9a9960f7 (diff)
downloadsrc-315bca194a14f3b9ec683675bafa8d990d16bfaf.tar.gz
src-315bca194a14f3b9ec683675bafa8d990d16bfaf.zip
Fix an early return in ctld UCL parser
If the UCL ctld parser encountered a port that used the CTL ioctl device, it fell into a special case that had an erroneous early return. This caused all configuration in the target following the port attribute to be skipped. Fix this by replacing the return with a continue so that the rest of the config is parsed correctly. Sponsored by: Dell EMC Isilon MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D31703 Reviewed by: bapt
-rw-r--r--usr.sbin/ctld/uclparse.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/usr.sbin/ctld/uclparse.c b/usr.sbin/ctld/uclparse.c
index b73e6b48b2f6..d02530d1b808 100644
--- a/usr.sbin/ctld/uclparse.c
+++ b/usr.sbin/ctld/uclparse.c
@@ -847,7 +847,7 @@ uclparse_target(const char *name, const ucl_object_t *top)
return (1);
}
- return (0);
+ continue;
}
pp = pport_find(conf, value);