diff options
| author | Mateusz Guzik <mjg@FreeBSD.org> | 2021-05-18 19:05:42 +0000 |
|---|---|---|
| committer | Mateusz Guzik <mjg@FreeBSD.org> | 2021-06-02 15:00:21 +0000 |
| commit | 3b78559094fea6320b925966a05cc14416b71c4a (patch) | |
| tree | 1008b435304a85e3dd7f963ef5c2884c76bf9bdf | |
| parent | a9ff49e0288b8844ddc6fb2a278ec652908d30cc (diff) | |
| download | src-3b78559094fea6320b925966a05cc14416b71c4a.tar.gz src-3b78559094fea6320b925966a05cc14416b71c4a.zip | |
lockprof: retire lock_prof_skipcount
The implementation uses a global variable for *ALL* calls, defeating the
point of sampling in the first place. Remove it as it clearly remains
unused.
(cherry picked from commit fca5cfd584d81ca291dbd898a8ff60c52d8c3c42)
| -rw-r--r-- | sys/kern/subr_lock.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/sys/kern/subr_lock.c b/sys/kern/subr_lock.c index b69ee349482c..09113836efe5 100644 --- a/sys/kern/subr_lock.c +++ b/sys/kern/subr_lock.c @@ -277,7 +277,6 @@ static volatile int lock_prof_resetting; static int lock_prof_rejected; static int lock_prof_skipspin; -static int lock_prof_skipcount; #ifndef USE_CPU_NANOSECONDS uint64_t @@ -596,7 +595,6 @@ void lock_profile_obtain_lock_success(struct lock_object *lo, int contested, uint64_t waittime, const char *file, int line) { - static int lock_prof_count; struct lock_profile_object *l; int spin; @@ -606,9 +604,6 @@ lock_profile_obtain_lock_success(struct lock_object *lo, int contested, /* don't reset the timer when/if recursing */ if (!lock_prof_enable || (lo->lo_flags & LO_NOPROFILE)) return; - if (lock_prof_skipcount && - (++lock_prof_count % lock_prof_skipcount) != 0) - return; spin = (LOCK_CLASS(lo)->lc_flags & LC_SPINLOCK) ? 1 : 0; if (spin && lock_prof_skipspin == 1) return; @@ -731,8 +726,6 @@ static SYSCTL_NODE(_debug_lock, OID_AUTO, prof, "lock profiling"); SYSCTL_INT(_debug_lock_prof, OID_AUTO, skipspin, CTLFLAG_RW, &lock_prof_skipspin, 0, "Skip profiling on spinlocks."); -SYSCTL_INT(_debug_lock_prof, OID_AUTO, skipcount, CTLFLAG_RW, - &lock_prof_skipcount, 0, "Sample approximately every N lock acquisitions."); SYSCTL_INT(_debug_lock_prof, OID_AUTO, rejected, CTLFLAG_RD, &lock_prof_rejected, 0, "Number of rejected profiling records"); SYSCTL_PROC(_debug_lock_prof, OID_AUTO, stats, |