diff options
author | Kristof Provost <kp@FreeBSD.org> | 2024-05-06 09:39:08 +0000 |
---|---|---|
committer | Kristof Provost <kp@FreeBSD.org> | 2024-05-06 09:39:08 +0000 |
commit | 43387b4e574043b78a58c8bcb7575161b055fce1 (patch) | |
tree | aeb91cb6072eddb9a8df1c105a44594637794adc | |
parent | 7929aeebbde17fcd7e1eb4e7569aba5e376d5d50 (diff) | |
download | src-43387b4e574043b78a58c8bcb7575161b055fce1.tar.gz src-43387b4e574043b78a58c8bcb7575161b055fce1.zip |
if: guard against if_ioctl being NULL
There are situations where an struct ifnet has a NULL if_ioctl pointer.
For example, e6000sw creates such struct ifnets for each of its ports so it can
call into the MII code.
If there is then a link state event this calls do_link_state_change()
-> rtnl_handle_ifevent() -> dump_iface() -> get_operstate() ->
get_operstate_ether(). That wants to know if the link is up or down, so it tries
to ioctl(SIOCGIFMEDIA), which doesn't go well if if_ioctl is NULL.
Guard against this, and return EOPNOTSUPP.
PR: 275920
MFC ater: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")
-rw-r--r-- | sys/net/if.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sys/net/if.c b/sys/net/if.c index 9f44223af0dd..c3c27fbf678f 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -4871,6 +4871,9 @@ if_resolvemulti(if_t ifp, struct sockaddr **srcs, struct sockaddr *dst) int if_ioctl(if_t ifp, u_long cmd, void *data) { + if (ifp->if_ioctl == NULL) + return (EOPNOTSUPP); + return (ifp->if_ioctl(ifp, cmd, data)); } |