diff options
| author | Caleb St. John <yocalebo@gmail.com> | 2021-03-26 18:00:14 +0000 |
|---|---|---|
| committer | Ryan Moeller <freqlabs@FreeBSD.org> | 2021-03-29 15:13:16 +0000 |
| commit | 4fd5354e85e4e72b91e7690595173b3bbde21490 (patch) | |
| tree | 67ff9d4b05cd0e057a40d9673a1c8ff3cb1039ce | |
| parent | 57593b2bca76db683ec6c589c1b051132181d55b (diff) | |
| download | src-4fd5354e85e4e72b91e7690595173b3bbde21490.tar.gz src-4fd5354e85e4e72b91e7690595173b3bbde21490.zip | |
rpc.lockd: Unconditionally close fds as daemon
When lockd is configured with a debug level of > 0 and foreground == 0,
the process is daemonized with a truth noclose argument to daemon().
This doesn't seem to be the desired behavior because that prevents
stdout and stderr from being closed, however, stdout and stderr aren't
used anywhere else. Furthermore, the man pages state that with a higher
debug level it will use the syslog facilities to do so.
Submitted by: Caleb St. John
Discussed with: rmacklem
MFC after: 3 days
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D29415
(cherry picked from commit badcfbacf3840a4097bb79192054481c7674e7d2)
| -rw-r--r-- | usr.sbin/rpc.lockd/lockd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/usr.sbin/rpc.lockd/lockd.c b/usr.sbin/rpc.lockd/lockd.c index 9aac9273b3fd..e25cef9993bb 100644 --- a/usr.sbin/rpc.lockd/lockd.c +++ b/usr.sbin/rpc.lockd/lockd.c @@ -426,7 +426,7 @@ main(int argc, char **argv) * Note that it is NOT sensible to run this program from inetd - the * protocol assumes that it will run immediately at boot time. */ - if ((foreground == 0) && daemon(0, debug_level > 0)) { + if ((foreground == 0) && daemon(0, 0)) { err(1, "cannot fork"); /* NOTREACHED */ } |