aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans Petter Selasky <hselasky@FreeBSD.org>2022-05-19 08:10:48 +0000
committerHans Petter Selasky <hselasky@FreeBSD.org>2022-05-19 08:13:06 +0000
commit527762b2f776381569bd662ce236d2845234c0a7 (patch)
treea07a6e18ee327717dd047a9222930c5d1338d0e8
parentad7741ff693a39bab59b75e432bd922a62f3ef0a (diff)
downloadsrc-527762b2f776381569bd662ce236d2845234c0a7.tar.gz
src-527762b2f776381569bd662ce236d2845234c0a7.zip
mlx4: Fix a memory leak bug.
In function mlx4_opreq_action(), pointer "mailbox" is not released, when mlx4_cmd_box() return and error, causing a memory leak bug. Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can free this pointer. Linux commit: febfd9d3c7f74063e8e630b15413ca91b567f963 PR: 264056 MFC after: 1 week Sponsored by: NVIDIA Networking
-rw-r--r--sys/dev/mlx4/mlx4_core/mlx4_fw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/mlx4/mlx4_core/mlx4_fw.c b/sys/dev/mlx4/mlx4_core/mlx4_fw.c
index 68aa7e76c79d..de83a3bf5a76 100644
--- a/sys/dev/mlx4/mlx4_core/mlx4_fw.c
+++ b/sys/dev/mlx4/mlx4_core/mlx4_fw.c
@@ -2702,7 +2702,7 @@ void mlx4_opreq_action(struct work_struct *work)
if (err) {
mlx4_err(dev, "Failed to retrieve required operation: %d\n",
err);
- return;
+ goto out;
}
MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);