diff options
| author | John Baldwin <jhb@FreeBSD.org> | 2023-10-16 22:13:31 +0000 |
|---|---|---|
| committer | John Baldwin <jhb@FreeBSD.org> | 2023-10-16 22:13:31 +0000 |
| commit | 5307bbcc038f878b4b3714f03a2c824a0caeba4f (patch) | |
| tree | 27e4e84a83c71ad5d146bf2e6fdc6b812f1a6f01 | |
| parent | ccd0f34d8585cba727dd17a381309855af655b82 (diff) | |
| download | src-5307bbcc038f878b4b3714f03a2c824a0caeba4f.tar.gz src-5307bbcc038f878b4b3714f03a2c824a0caeba4f.zip | |
bsdinstall partedit: Apply changes from scripted installs
I got a check inverted in a previous cleanup commit and as a result
partedit was only applying GEOM changes (and generating an /etc/fstab)
if it got an error reading the current GEOM mesh. Instead, it needed
to do those actions if it succeeded in reading the mesh.
The lack of /etc/fstab meant that bsdinstall mount didn't mount
anything in a scripted install.
PR: 273723
Reported by: Andrey Fesenko <andrey@bsdnir.info>
Reported by: Michal Nowak <mnowak@startmail.com>
Reviewed by: cognet, brooks
Fixes: 230990991965 bsdinstall: Handle errors from geom_gettree.
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D42236
| -rw-r--r-- | usr.sbin/bsdinstall/partedit/partedit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/usr.sbin/bsdinstall/partedit/partedit.c b/usr.sbin/bsdinstall/partedit/partedit.c index 668824725ac8..bb2580789fe8 100644 --- a/usr.sbin/bsdinstall/partedit/partedit.c +++ b/usr.sbin/bsdinstall/partedit/partedit.c @@ -215,7 +215,7 @@ main(int argc, const char **argv) if (prompt == NULL) { error = geom_gettree(&mesh); - if (error != 0) { + if (error == 0) { if (validate_setup()) { error = apply_changes(&mesh); } else { |