diff options
| author | Konstantin Belousov <kib@FreeBSD.org> | 2022-01-23 00:33:18 +0000 |
|---|---|---|
| committer | Konstantin Belousov <kib@FreeBSD.org> | 2022-02-07 09:38:50 +0000 |
| commit | 773d9d7e40dbd1d37517ba20d983fc7d31f5cc8b (patch) | |
| tree | b0917d2beda5ffe9cd477900f348b12783f9af7a | |
| parent | 8fcc0d7b393904702bef5cbe1b760454b02ce0fb (diff) | |
| download | src-773d9d7e40dbd1d37517ba20d983fc7d31f5cc8b.tar.gz src-773d9d7e40dbd1d37517ba20d983fc7d31f5cc8b.zip | |
ffs_snapblkfree(): add a comment explaining lockmgr invocation
(cherry picked from commit 4559700a0a99376640a8913d08bdf0cfb0124d4a)
| -rw-r--r-- | sys/ufs/ffs/ffs_snapshot.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index a0d16d9eccef..cb5c4f5e2481 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -1807,9 +1807,15 @@ retry: VI_UNLOCK(devvp); return (0); } + + /* + * Use LK_SLEEPFAIL because sn might be freed under us while + * both devvp interlock and snaplk are not owned. + */ if (lockmgr(&sn->sn_lock, LK_INTERLOCK | LK_EXCLUSIVE | LK_SLEEPFAIL, VI_MTX(devvp)) != 0) goto retry; + TAILQ_FOREACH(ip, &sn->sn_head, i_nextsnap) { vp = ITOV(ip); if (DOINGSOFTDEP(vp)) |