diff options
author | Mitchell Horne <mhorne@FreeBSD.org> | 2023-12-04 15:46:48 +0000 |
---|---|---|
committer | Mitchell Horne <mhorne@FreeBSD.org> | 2023-12-07 00:22:19 +0000 |
commit | 7fd0973775aa9a293739afa0c5068f77ba88cb17 (patch) | |
tree | 5ffeef3786d77723faa29722f86899c5d9e3ce9e | |
parent | 05c55eed44e53a3a5473451d105f81ce36ef375a (diff) | |
download | src-7fd0973775aa9a293739afa0c5068f77ba88cb17.tar.gz src-7fd0973775aa9a293739afa0c5068f77ba88cb17.zip |
busdma: emit a warning for use of filters
Filter functions are deprecated, and unused in the tree. If either of
the filter or filterarg arguments to bus_dma_tag_create() are non-NULL,
print a warning.
This is a direct commit to stable/13.
Reviewed by: jhb
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D42897
-rw-r--r-- | sys/arm/arm/busdma_machdep.c | 4 | ||||
-rw-r--r-- | sys/arm64/arm64/busdma_machdep.c | 4 | ||||
-rw-r--r-- | sys/powerpc/powerpc/busdma_machdep.c | 4 | ||||
-rw-r--r-- | sys/riscv/riscv/busdma_machdep.c | 4 | ||||
-rw-r--r-- | sys/x86/x86/busdma_machdep.c | 4 |
5 files changed, 20 insertions, 0 deletions
diff --git a/sys/arm/arm/busdma_machdep.c b/sys/arm/arm/busdma_machdep.c index 747bf4e7b5bd..9a3378141207 100644 --- a/sys/arm/arm/busdma_machdep.c +++ b/sys/arm/arm/busdma_machdep.c @@ -474,6 +474,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, /* Return a NULL tag on failure */ *dmat = NULL; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + newtag = (bus_dma_tag_t)malloc(sizeof(*newtag), M_BUSDMA, M_ZERO | M_NOWAIT); if (newtag == NULL) { diff --git a/sys/arm64/arm64/busdma_machdep.c b/sys/arm64/arm64/busdma_machdep.c index 44f186adb014..cd3864bf5d18 100644 --- a/sys/arm64/arm64/busdma_machdep.c +++ b/sys/arm64/arm64/busdma_machdep.c @@ -196,6 +196,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, struct bus_dma_tag_common *tc; int error; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + if (parent == NULL) { error = bus_dma_bounce_impl.tag_create(parent, alignment, boundary, lowaddr, highaddr, filter, filterarg, maxsize, diff --git a/sys/powerpc/powerpc/busdma_machdep.c b/sys/powerpc/powerpc/busdma_machdep.c index 6b7463ad5aa0..710a90f1f1d8 100644 --- a/sys/powerpc/powerpc/busdma_machdep.c +++ b/sys/powerpc/powerpc/busdma_machdep.c @@ -239,6 +239,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, return (EINVAL); } + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + /* Return a NULL tag on failure */ *dmat = NULL; diff --git a/sys/riscv/riscv/busdma_machdep.c b/sys/riscv/riscv/busdma_machdep.c index 433f55f082a7..509a000d655d 100644 --- a/sys/riscv/riscv/busdma_machdep.c +++ b/sys/riscv/riscv/busdma_machdep.c @@ -197,6 +197,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, struct bus_dma_tag_common *tc; int error; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + if (parent == NULL) { error = bus_dma_bounce_impl.tag_create(parent, alignment, boundary, lowaddr, highaddr, filter, filterarg, maxsize, diff --git a/sys/x86/x86/busdma_machdep.c b/sys/x86/x86/busdma_machdep.c index 62e57022acf8..36b1894b9615 100644 --- a/sys/x86/x86/busdma_machdep.c +++ b/sys/x86/x86/busdma_machdep.c @@ -219,6 +219,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, struct bus_dma_tag_common *tc; int error; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + if (parent == NULL) { error = bus_dma_bounce_impl.tag_create(parent, alignment, boundary, lowaddr, highaddr, filter, filterarg, maxsize, |