diff options
| author | Dimitry Andric <dim@FreeBSD.org> | 2023-12-21 22:35:17 +0000 |
|---|---|---|
| committer | Dimitry Andric <dim@FreeBSD.org> | 2023-12-24 14:01:35 +0000 |
| commit | 9734bad3611c291798727ae9020f876304d4e849 (patch) | |
| tree | ebdbe1e158b39b4bfb39c9e385fa5a94d25eb88c | |
| parent | 98a75346bb6521c747dc976842456730627e93e9 (diff) | |
| download | src-9734bad3611c291798727ae9020f876304d4e849.tar.gz src-9734bad3611c291798727ae9020f876304d4e849.zip | |
Fix snprintf truncation in telnet
Building telnet with clang 18 results in the following warning:
contrib/telnet/telnet/telnet.c:231:5: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 11 [-Werror,-Wformat-truncation]
231 | snprintf(temp2, sizeof(temp2), "%c%c%c%c....%c%c", IAC, SB, TELOPT_COMPORT,
| ^
The temp2 buffer is 10 chars, while the format string also consists of
10 chars. Therefore, snprintf(3) will truncate the last character, 'SE'
(end sub negotation) in this case.
Bump the buffer to 11 chars to avoid truncation.
MFC after: 3 days
(cherry picked from commit c794d188222a4d3414233ff9630d47eedc090fbe)
| -rw-r--r-- | contrib/telnet/telnet/telnet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/telnet/telnet/telnet.c b/contrib/telnet/telnet/telnet.c index b6b2432ef3ec..a98dad499c7b 100644 --- a/contrib/telnet/telnet/telnet.c +++ b/contrib/telnet/telnet/telnet.c @@ -208,7 +208,7 @@ unsigned char ComPortBaudRate[256]; void DoBaudRate(char *arg) { - char *temp, temp2[10]; + char *temp, temp2[11]; int i; uint32_t baudrate; |