diff options
| author | Olivier Certner <olce@FreeBSD.org> | 2024-01-05 15:23:19 +0000 |
|---|---|---|
| committer | Olivier Certner <olce@FreeBSD.org> | 2024-01-10 17:50:19 +0000 |
| commit | a1e37beb45d270ae9926eff3b93e9398d08c94e5 (patch) | |
| tree | 191264cafbaa0366c7c659f67e4f79773d6a3b91 | |
| parent | 6211cd4be32dfdc51b5ac452d4ead98a36ec42a6 (diff) | |
| download | src-a1e37beb45d270ae9926eff3b93e9398d08c94e5.tar.gz src-a1e37beb45d270ae9926eff3b93e9398d08c94e5.zip | |
cr_bsd_visible(): Style fixes
Explicitly test for non-zero return codes.
Separate assignment and testing of 'error' in distinct lines.
Reviewed by: emaste, kib
Approved by: emaste (mentor)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D43335
| -rw-r--r-- | sys/kern/kern_prot.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index 0ebedcd72fc3..be8e0b14add2 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -1463,11 +1463,14 @@ cr_bsd_visible(struct ucred *u1, struct ucred *u2) { int error; - if ((error = cr_canseeotheruids(u1, u2))) + error = cr_canseeotheruids(u1, u2); + if (error != 0) return (error); - if ((error = cr_canseeothergids(u1, u2))) + error = cr_canseeothergids(u1, u2); + if (error != 0) return (error); - if ((error = cr_canseejailproc(u1, u2))) + error = cr_canseejailproc(u1, u2); + if (error != 0) return (error); return (0); } |