aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyle Evans <kevans@FreeBSD.org>2021-01-05 21:49:46 +0000
committerKyle Evans <kevans@FreeBSD.org>2021-01-24 04:05:00 +0000
commitad62ba026e4d91f01569ca17f3b9f900a60cc08f (patch)
treeb6bc3c5803ac1cc11bf05be58e0986efa8d33649
parent4b74a4d4e26788ae8e47ec10172ac80ce435dbb5 (diff)
downloadsrc-ad62ba026e4d91f01569ca17f3b9f900a60cc08f.tar.gz
src-ad62ba026e4d91f01569ca17f3b9f900a60cc08f.zip
du: tests: make H_flag tests more strict about output requirements
The current version of this test will effectively pass as long as one of the specified paths is in the output, and it could even be a subset of one of the paths. Strengthen up the test a little bit: * Specify beginning/end anchors for each path * Add egrep -v checks to make sure we don't have any *additional* paths * Ratchet down paths2 to exactly the two paths we expect to appear (cherry picked from commit 3c5c39c7ad8f010cfa5fc0db43d15d1964b4cf16)
-rwxr-xr-xusr.bin/du/tests/du_test.sh16
1 files changed, 12 insertions, 4 deletions
diff --git a/usr.bin/du/tests/du_test.sh b/usr.bin/du/tests/du_test.sh
index 4a8f11e83ff5..92a26deae02b 100755
--- a/usr.bin/du/tests/du_test.sh
+++ b/usr.bin/du/tests/du_test.sh
@@ -45,17 +45,25 @@ H_flag_head()
H_flag_body()
{
local paths1='testdir/A/B testdir/A testdir/C testdir'
- local paths2='testdir/A/B testdir/A testdir/C testdir'
+ local paths2='testdir/C/B testdir/C'
local lineprefix="^[0-9]+$(printf "\t")"
- local sep="\n${lineprefix}"
+ local sep="\$\n${lineprefix}"
atf_check mkdir testdir
atf_check -x "cd testdir && mkdir A && touch A/B && ln -s A C"
atf_check -o save:du.out du -aAH testdir
- atf_check egrep -q "${lineprefix}$(echo $paths1 | sed -e "s/ /$sep/g")" du.out
+ atf_check egrep -q "${lineprefix}$(echo $paths1 | sed -e "s/ /$sep/g")$" du.out
+ # Check that the output doesn't contain any lines (i.e. paths) that we
+ # did not expect it to contain from $paths1.
+ atf_check -s exit:1 egrep -vq "${lineprefix}$(echo $paths1 | sed -e "s/ /$sep/g")$" du.out
+
atf_check -o save:du_C.out du -aAH testdir/C
- atf_check egrep -q "${lineprefix}$(echo $paths2 | sed -e "s/ /$sep/g")" du_C.out
+ atf_check egrep -q "${lineprefix}$(echo $paths2 | sed -e "s/ /$sep/g")$" du_C.out
+
+ # Check that the output doesn't contain any lines (i.e. paths) that we
+ # did not expect it to contain from $paths2.
+ atf_check -s exit:1 egrep -vq "${lineprefix}$(echo $paths2 | sed -e "s/ /$sep/g")$" du_C.out
}
atf_test_case I_flag