aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMateusz Guzik <mjg@FreeBSD.org>2021-08-13 09:29:57 +0000
committerMateusz Guzik <mjg@FreeBSD.org>2021-08-18 09:44:43 +0000
commitad9671955a40ed69432e66d4ff6579c42a6e048d (patch)
treeccbab76361dc971fc08eec24183eca5cd62492d4
parent64f6c8d616b95a6ca153dd7d9e07bad3cf86e51f (diff)
downloadsrc-ad9671955a40ed69432e66d4ff6579c42a6e048d.tar.gz
src-ad9671955a40ed69432e66d4ff6579c42a6e048d.zip
ip_reass: drop the volatile keyword from nfrags and mark with __exclusive_cache_line
The keyword adds nothing as all operations on the var are performed through atomic_* Reviewed by: kp Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D31526 (cherry picked from commit d2b95af1c27ed51d72bef5d9f3d89860edc4fd40)
-rw-r--r--sys/netinet/ip_reass.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/netinet/ip_reass.c b/sys/netinet/ip_reass.c
index f5cc6ad68125..8a071345677a 100644
--- a/sys/netinet/ip_reass.c
+++ b/sys/netinet/ip_reass.c
@@ -137,12 +137,12 @@ ipq_drop(struct ipqbucket *bucket, struct ipq *fp)
#define IP_MAXFRAGPACKETS (imin(IP_MAXFRAGS, IPREASS_NHASH * 50))
static int maxfrags;
-static volatile u_int nfrags;
+static u_int __exclusive_cache_line nfrags;
SYSCTL_INT(_net_inet_ip, OID_AUTO, maxfrags, CTLFLAG_RW,
&maxfrags, 0,
"Maximum number of IPv4 fragments allowed across all reassembly queues");
SYSCTL_UINT(_net_inet_ip, OID_AUTO, curfrags, CTLFLAG_RD,
- __DEVOLATILE(u_int *, &nfrags), 0,
+ &nfrags, 0,
"Current number of IPv4 fragments across all reassembly queues");
VNET_DEFINE_STATIC(uma_zone_t, ipq_zone);