diff options
| author | Kyle Evans <kevans@FreeBSD.org> | 2023-03-09 05:29:30 +0000 |
|---|---|---|
| committer | Kyle Evans <kevans@FreeBSD.org> | 2023-03-17 05:04:11 +0000 |
| commit | d18524b6f7205e3d31b76227ddc850ab65d352e3 (patch) | |
| tree | 5b399fa1d92bde34d3cb4f26958af07fff0215a6 | |
| parent | 6fdb5daba679128b11b6ce3a401fb74d0db07fd8 (diff) | |
| download | src-d18524b6f7205e3d31b76227ddc850ab65d352e3.tar.gz src-d18524b6f7205e3d31b76227ddc850ab65d352e3.zip | |
grep: remove tautological condition
st_size is an off_t, it cannot hold values larger than OFF_MAX.
CID: 1008931
(cherry picked from commit f6d6c66889001208aee7b0c46efe1c8ddffda57c)
(cherry picked from commit c816aea7abcf7a6e9471907dcb7ee3d7969a0ab3)
(cherry picked from commit b61758494286db075d5c6b68a5f2e7522e7be394)
| -rw-r--r-- | usr.bin/grep/file.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/usr.bin/grep/file.c b/usr.bin/grep/file.c index 8577572c2887..787e8fbe03bb 100644 --- a/usr.bin/grep/file.c +++ b/usr.bin/grep/file.c @@ -186,8 +186,7 @@ grep_open(const char *path) if (filebehave == FILE_MMAP) { struct stat st; - if ((fstat(f->fd, &st) == -1) || (st.st_size > OFF_MAX) || - (!S_ISREG(st.st_mode))) + if (fstat(f->fd, &st) == -1 || !S_ISREG(st.st_mode)) filebehave = FILE_STDIO; else { int flags = MAP_PRIVATE | MAP_NOCORE | MAP_NOSYNC; |