aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Johnston <markj@FreeBSD.org>2023-12-05 18:47:03 +0000
committerMark Johnston <markj@FreeBSD.org>2023-12-12 00:30:05 +0000
commitd264ddb9c7f8739be22170ec660110a0f4c2ec8f (patch)
tree1d00daafd02646cfd3c98e3eda2d4fec0829a8a3
parent8e41bbf2457ee2269935ccab405de120f54db3c4 (diff)
downloadsrc-d264ddb9c7f8739be22170ec660110a0f4c2ec8f.tar.gz
src-d264ddb9c7f8739be22170ec660110a0f4c2ec8f.zip
bhnd: Correct the softc size in the siba_bhndb_driver definition
struct siba_bhndb_softc embeds struct siba_softc and adds an extra field, "quirks". In practice, this bug was harmless since "quirks" is unconditionally initialized during driver attach and would have lived in the redzone of the softc allocation, but KASAN catches the out-of-bounds access. PR: 275515 Reported by: Frank Hilgendorf <frank.hilgendorf@posteo.de> MFC after: 1 week (cherry picked from commit 4c3aa00c0a0093c78f42d138bb9eef9b1a7cbb39)
-rw-r--r--sys/dev/bhnd/siba/siba_bhndb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/bhnd/siba/siba_bhndb.c b/sys/dev/bhnd/siba/siba_bhndb.c
index b806f9535e73..59243be18938 100644
--- a/sys/dev/bhnd/siba/siba_bhndb.c
+++ b/sys/dev/bhnd/siba/siba_bhndb.c
@@ -286,7 +286,7 @@ static device_method_t siba_bhndb_methods[] = {
};
DEFINE_CLASS_2(bhnd, siba_bhndb_driver, siba_bhndb_methods,
- sizeof(struct siba_softc), bhnd_bhndb_driver, siba_driver);
+ sizeof(struct siba_bhndb_softc), bhnd_bhndb_driver, siba_driver);
DRIVER_MODULE(siba_bhndb, bhndb, siba_bhndb_driver, NULL, NULL);