aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEd Maste <emaste@FreeBSD.org>2023-05-05 17:43:33 +0000
committerEd Maste <emaste@FreeBSD.org>2023-05-10 00:18:19 +0000
commite32fecd0c2c3ee37c47ee100f169e7eb0282a873 (patch)
treec92b5e7e04a6a29845bf589c4429575b71a1ad43
parentc55b7e522629cb78adeb54bd9964304481d55eab (diff)
downloadsrc-e32fecd0c2c3ee37c47ee100f169e7eb0282a873.tar.gz
src-e32fecd0c2c3ee37c47ee100f169e7eb0282a873.zip
loader: install help files only once
Every file should be installed exactly once by `make installworld`. This is especially important for pkgbase. Loader help files were being installed by each loader variant (e.g., the simp, lua, and 4th EFI loaders). Add a (slightly hacky) mechanism to skip installing help files for all but one variant. PR: 271178 Reviewed by: imp Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D40021
-rw-r--r--stand/efi/loader_4th/Makefile1
-rw-r--r--stand/efi/loader_lua/Makefile1
-rw-r--r--stand/i386/loader_4th/Makefile1
-rw-r--r--stand/i386/loader_lua/Makefile1
-rw-r--r--stand/loader.mk2
-rw-r--r--stand/userboot/userboot_4th/Makefile1
-rw-r--r--stand/userboot/userboot_lua/Makefile1
7 files changed, 8 insertions, 0 deletions
diff --git a/stand/efi/loader_4th/Makefile b/stand/efi/loader_4th/Makefile
index 3659f7efe673..a85fcdbb70b9 100644
--- a/stand/efi/loader_4th/Makefile
+++ b/stand/efi/loader_4th/Makefile
@@ -1,6 +1,7 @@
# $FreeBSD$
LOADER_INTERP=4th
+INSTALL_LOADER_HELP_FILE=no
.include "../loader/Makefile"
diff --git a/stand/efi/loader_lua/Makefile b/stand/efi/loader_lua/Makefile
index 3a4268440cf6..3766588015ad 100644
--- a/stand/efi/loader_lua/Makefile
+++ b/stand/efi/loader_lua/Makefile
@@ -1,6 +1,7 @@
# $FreeBSD$
LOADER_INTERP=lua
+INSTALL_LOADER_HELP_FILE=no
.include "../loader/Makefile"
diff --git a/stand/i386/loader_4th/Makefile b/stand/i386/loader_4th/Makefile
index 3659f7efe673..a85fcdbb70b9 100644
--- a/stand/i386/loader_4th/Makefile
+++ b/stand/i386/loader_4th/Makefile
@@ -1,6 +1,7 @@
# $FreeBSD$
LOADER_INTERP=4th
+INSTALL_LOADER_HELP_FILE=no
.include "../loader/Makefile"
diff --git a/stand/i386/loader_lua/Makefile b/stand/i386/loader_lua/Makefile
index 3a4268440cf6..3766588015ad 100644
--- a/stand/i386/loader_lua/Makefile
+++ b/stand/i386/loader_lua/Makefile
@@ -1,6 +1,7 @@
# $FreeBSD$
LOADER_INTERP=lua
+INSTALL_LOADER_HELP_FILE=no
.include "../loader/Makefile"
diff --git a/stand/loader.mk b/stand/loader.mk
index b30e9f4e66b7..2048fec750e4 100644
--- a/stand/loader.mk
+++ b/stand/loader.mk
@@ -171,8 +171,10 @@ CFLAGS+= -DELF_VERBOSE
HELP_FILES+= ${LDRSRC}/help.common
CFLAGS+= -DHELP_FILENAME=\"${HELP_FILENAME}\"
+.if ${INSTALL_LOADER_HELP_FILE:Uyes} == "yes"
CLEANFILES+= ${HELP_FILENAME}
FILES+= ${HELP_FILENAME}
+.endif
${HELP_FILENAME}: ${HELP_FILES}
cat ${HELP_FILES} | awk -f ${LDRSRC}/merge_help.awk > ${.TARGET}
diff --git a/stand/userboot/userboot_4th/Makefile b/stand/userboot/userboot_4th/Makefile
index a96efa8a52ba..b4b4b895e29b 100644
--- a/stand/userboot/userboot_4th/Makefile
+++ b/stand/userboot/userboot_4th/Makefile
@@ -1,6 +1,7 @@
# $FreeBSD$
LOADER_INTERP=4th
+INSTALL_LOADER_HELP_FILE=no
.include "../userboot/Makefile"
diff --git a/stand/userboot/userboot_lua/Makefile b/stand/userboot/userboot_lua/Makefile
index d5b95c53641b..bba0f4a3fd71 100644
--- a/stand/userboot/userboot_lua/Makefile
+++ b/stand/userboot/userboot_lua/Makefile
@@ -1,6 +1,7 @@
# $FreeBSD$
LOADER_INTERP=lua
+INSTALL_LOADER_HELP_FILE=no
.include "../userboot/Makefile"