aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMoritz Schmitt <moritz@schmi.tt>2021-04-27 01:59:12 +0000
committerBaptiste Daroussin <bapt@FreeBSD.org>2021-04-27 02:01:49 +0000
commite869d3c60147bbb226b5ad97d2ef73391aeebafa (patch)
treee06520117f59f6eedf02f23b682b534583f9c64f
parent689724cb23c2acf58091c80f27de4823d7cd87ca (diff)
downloadsrc-e869d3c60147bbb226b5ad97d2ef73391aeebafa.tar.gz
src-e869d3c60147bbb226b5ad97d2ef73391aeebafa.zip
Make pkg(7) use environment variables specified in pkg.conf
Modify /usr/sbin/pkg to use environment variables specified in pkg.conf. This allows control over underlying libraries like fetch(3), which can be configured by setting HTTP_PROXY. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D29820
-rw-r--r--usr.sbin/pkg/config.c29
-rw-r--r--usr.sbin/pkg/config.h2
2 files changed, 27 insertions, 4 deletions
diff --git a/usr.sbin/pkg/config.c b/usr.sbin/pkg/config.c
index 6f723254d394..3a9ad63ae407 100644
--- a/usr.sbin/pkg/config.c
+++ b/usr.sbin/pkg/config.c
@@ -44,6 +44,7 @@ __FBSDID("$FreeBSD$");
#include <paths.h>
#include <stdbool.h>
#include <unistd.h>
+#include <ctype.h>
#include "config.h"
@@ -134,6 +135,15 @@ static struct config_entry c[] = {
NULL,
false,
false
+ },
+ [PKG_ENV] = {
+ PKG_CONFIG_OBJECT,
+ "PKG_ENV",
+ NULL,
+ NULL,
+ NULL,
+ false,
+ false,
}
};
@@ -205,11 +215,11 @@ static void
config_parse(const ucl_object_t *obj, pkg_conf_file_t conftype)
{
struct sbuf *buf = sbuf_new_auto();
- const ucl_object_t *cur, *seq;
- ucl_object_iter_t it = NULL, itseq = NULL;
+ const ucl_object_t *cur, *seq, *tmp;
+ ucl_object_iter_t it = NULL, itseq = NULL, it_obj = NULL;
struct config_entry *temp_config;
struct config_value *cv;
- const char *key;
+ const char *key, *evkey;
int i;
size_t j;
@@ -224,7 +234,7 @@ config_parse(const ucl_object_t *obj, pkg_conf_file_t conftype)
if (conftype == CONFFILE_PKG) {
for (j = 0; j < strlen(key); ++j)
- sbuf_putc(buf, key[j]);
+ sbuf_putc(buf, toupper(key[j]));
sbuf_finish(buf);
} else if (conftype == CONFFILE_REPO) {
if (strcasecmp(key, "url") == 0)
@@ -285,6 +295,17 @@ config_parse(const ucl_object_t *obj, pkg_conf_file_t conftype)
temp_config[i].value =
strdup(ucl_object_toboolean(cur) ? "yes" : "no");
break;
+ case PKG_CONFIG_OBJECT:
+ if (strcmp(c[i].key, "PKG_ENV") == 0) {
+ while ((tmp =
+ ucl_iterate_object(cur, &it_obj, true))) {
+ evkey = ucl_object_key(tmp);
+ if (evkey != NULL && *evkey != '\0') {
+ setenv(evkey, ucl_object_tostring_forced(tmp), 1);
+ }
+ }
+ }
+ break;
default:
/* Normal string value. */
temp_config[i].value = strdup(ucl_object_tostring(cur));
diff --git a/usr.sbin/pkg/config.h b/usr.sbin/pkg/config.h
index afcd728abd92..87efd3c29e94 100644
--- a/usr.sbin/pkg/config.h
+++ b/usr.sbin/pkg/config.h
@@ -44,6 +44,7 @@ typedef enum {
FINGERPRINTS,
REPOS_DIR,
PUBKEY,
+ PKG_ENV,
CONFIG_SIZE
} pkg_config_key;
@@ -51,6 +52,7 @@ typedef enum {
PKG_CONFIG_STRING=0,
PKG_CONFIG_BOOL,
PKG_CONFIG_LIST,
+ PKG_CONFIG_OBJECT
} pkg_config_t;
typedef enum {