diff options
| author | orange30 <44566632+orange30@users.noreply.github.com> | 2021-09-01 15:37:36 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2021-09-10 13:45:26 +0000 |
| commit | f5777c123a6382f5fdc9732a87c8fa1ff672f148 (patch) | |
| tree | 356799cefbde2371c6efe16e4443e904e5cddf73 | |
| parent | 6598cababf6425181a755ec97c3fa66d7ee31393 (diff) | |
| download | src-f5777c123a6382f5fdc9732a87c8fa1ff672f148.tar.gz src-f5777c123a6382f5fdc9732a87c8fa1ff672f148.zip | |
net: Fix memory leaks upon arp_fillheader() failures
Free memory before return from arprequest_internal(). In in_arpinput(),
if arp_fillheader() fails, it should use goto drop.
Reviewed by: melifaro, imp, markj
MFC after: 1 week
Pull Request: https://github.com/freebsd/freebsd-src/pull/534
| -rw-r--r-- | sys/netinet/if_ether.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sys/netinet/if_ether.c b/sys/netinet/if_ether.c index 2f92d623feeb..5400f35d953f 100644 --- a/sys/netinet/if_ether.c +++ b/sys/netinet/if_ether.c @@ -418,6 +418,7 @@ arprequest_internal(struct ifnet *ifp, const struct in_addr *sip, linkhdrsize = sizeof(linkhdr); error = arp_fillheader(ifp, ah, 1, linkhdr, &linkhdrsize); if (error != 0 && error != EAFNOSUPPORT) { + m_freem(m); ARP_LOG(LOG_ERR, "Failed to calculate ARP header on %s: %d\n", if_name(ifp), error); return (error); @@ -1128,7 +1129,7 @@ reply: if (error != 0 && error != EAFNOSUPPORT) { ARP_LOG(LOG_ERR, "Failed to calculate ARP header on %s: %d\n", if_name(ifp), error); - return; + goto drop; } ro.ro_prepend = linkhdr; |