aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Belousov <kib@FreeBSD.org>2021-05-25 18:51:00 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2021-05-31 15:09:22 +0000
commitf62c7e54e9cc692603081328597ba0ba0d1f21cf (patch)
tree91992bf1ca69e977576f8dc7428f123bca76b18c
parent3a68546d2377d6e9776060043372d66f07022543 (diff)
downloadsrc-f62c7e54e9cc692603081328597ba0ba0d1f21cf.tar.gz
src-f62c7e54e9cc692603081328597ba0ba0d1f21cf.zip
Add thread_reap_barrier()
Reviewed by: hselasky,markj Sponsored by: Mellanox Technologies/NVidia Networking MFC after: 1 week Differential revision: https://reviews.freebsd.org/D30468
-rw-r--r--sys/kern/kern_thread.c32
-rw-r--r--sys/sys/proc.h1
2 files changed, 33 insertions, 0 deletions
diff --git a/sys/kern/kern_thread.c b/sys/kern/kern_thread.c
index 935d7071e452..b5983eb4beb7 100644
--- a/sys/kern/kern_thread.c
+++ b/sys/kern/kern_thread.c
@@ -710,6 +710,38 @@ thread_reap_callout_cb(void *arg __unused)
}
/*
+ * Calling this function guarantees that any thread that exited before
+ * the call is reaped when the function returns. By 'exited' we mean
+ * a thread removed from the process linkage with thread_unlink().
+ * Practically this means that caller must lock/unlock corresponding
+ * process lock before the call, to synchronize with thread_exit().
+ */
+void
+thread_reap_barrier(void)
+{
+ struct thread *td;
+ struct task *t;
+
+ td = curthread;
+
+ /*
+ * First do context switches to each CPU to ensure that all
+ * PCPU pc_deadthreads are moved to zombie list.
+ */
+ quiesce_all_cpus("", PDROP);
+
+ /*
+ * Second, fire the task in the same thread as normal
+ * thread_reap() is done, to serialize reaping.
+ */
+ t = malloc(sizeof(*t), M_TEMP, M_WAITOK);
+ TASK_INIT(t, 0, thread_reap_task_cb, t);
+ taskqueue_enqueue(taskqueue_thread, t);
+ taskqueue_drain(taskqueue_thread, t);
+ free(t, M_TEMP);
+}
+
+/*
* Allocate a thread.
*/
struct thread *
diff --git a/sys/sys/proc.h b/sys/sys/proc.h
index 2630c2b5a1d0..afa0be05d33a 100644
--- a/sys/sys/proc.h
+++ b/sys/sys/proc.h
@@ -1189,6 +1189,7 @@ int thread_create(struct thread *td, struct rtprio *rtp,
void thread_exit(void) __dead2;
void thread_free(struct thread *td);
void thread_link(struct thread *td, struct proc *p);
+void thread_reap_barrier(void);
int thread_single(struct proc *p, int how);
void thread_single_end(struct proc *p, int how);
void thread_stash(struct thread *td);