diff options
| author | Konstantin Belousov <kib@FreeBSD.org> | 2022-06-03 08:21:23 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2022-08-09 19:59:14 +0000 |
| commit | 056ffc74a7693808c843e15d85deee20abf5c4e2 (patch) | |
| tree | 309af545b83556c654448e0f8f4cef5aab10d66f /.github/workflows | |
| parent | 5430423b6d63b76548ed23efff5d33b7ebeefd05 (diff) | |
elf_note_prpsinfo: handle more failures from proc_getargv()
Resulting sbuf_len() from proc_getargv() might return 0 if user mangled
ps_strings enough. Also, sbuf_len() API contract is to return -1 if the
buffer overflowed. The later should not occur because get_ps_strings()
checks for catenated length, but check for this subtle detail explicitly
as well to be more resilent.
The end result is that p_comm is used in this situations.
Approved by: so
Security: FreeBSD-SA-22:09.elf
Reported by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Reviewed by: delphij, markj
admbugs: 988
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D35391
(cherry picked from commit 00d17cf342cd9f4f8fd1dcd79c8caec359145532)
(cherry picked from commit 8a44a2c644fc6d4ec1740fcc0b3ff01eac989ddf)
Diffstat (limited to '.github/workflows')
0 files changed, 0 insertions, 0 deletions