aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBaptiste Daroussin <bapt@FreeBSD.org>2026-06-09 14:19:56 +0000
committerBaptiste Daroussin <bapt@FreeBSD.org>2026-06-09 16:04:25 +0000
commit09d068e52722dee0ed65eb88c5ea5bff4bb2ba06 (patch)
tree597dfd6b2554e8ddf8645f444ea68057adcfa8c1
parent0211c8722ff2ac9367565e526e62837745bb2cce (diff)
nuageinit: fix shell injection in power_state_change delay and add test
-rwxr-xr-xlibexec/nuageinit/nuageinit2
-rw-r--r--libexec/nuageinit/tests/nuageinit.sh2
2 files changed, 2 insertions, 2 deletions
diff --git a/libexec/nuageinit/nuageinit b/libexec/nuageinit/nuageinit
index 6e900e01df4e..8ca1a2c558c8 100755
--- a/libexec/nuageinit/nuageinit
+++ b/libexec/nuageinit/nuageinit
@@ -748,7 +748,7 @@ local function power_state_change(obj)
end
-- Build shutdown command
- local cmd = "shutdown -" .. flag .. " " .. delay
+ local cmd = "shutdown -" .. flag .. " " .. nuage.shell_escape(delay)
if message then
cmd = cmd .. " " .. nuage.shell_escape(message)
end
diff --git a/libexec/nuageinit/tests/nuageinit.sh b/libexec/nuageinit/tests/nuageinit.sh
index ce574a350ecc..ab9e697076e1 100644
--- a/libexec/nuageinit/tests/nuageinit.sh
+++ b/libexec/nuageinit/tests/nuageinit.sh
@@ -1332,7 +1332,7 @@ power_state:
timeout: 30
condition: true
EOF
- atf_check -o inline:"shutdown -r +5 'Rebooting after configuration is complete'\n" \
+ atf_check -o inline:"shutdown -r '+5' 'Rebooting after configuration is complete'\n" \
/usr/libexec/nuageinit "${PWD}"/media/nuageinit postnet
true
}