aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Percival <cperciva@FreeBSD.org>2024-10-22 18:25:11 +0000
committerColin Percival <cperciva@FreeBSD.org>2024-11-03 16:01:27 +0000
commit1f6941760746367704c9f1fa730a00b99d4d46b2 (patch)
tree8483752b3a3ed14283b25e7d9e27ca688198f485
parentfffdfe2f6770946bb5d5204df0a97105e1dceccb (diff)
acpi_gpiobus: Narrow scope of NOT_YET
GPIO interrupts work just fine and will be used shortly. We still do not support GPIO_INTR_SHAREABLE however, so leave that within the NOT_YET scope. Reviwed by: andrew MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D47251 (cherry picked from commit 2d4219919a48aa6d67ae62e2b8859ffe3b035bd2)
-rw-r--r--sys/dev/gpio/acpi_gpiobus.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c
index 3b6fc6dde674..9828170daeca 100644
--- a/sys/dev/gpio/acpi_gpiobus.c
+++ b/sys/dev/gpio/acpi_gpiobus.c
@@ -52,8 +52,6 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
uint32_t flags = 0;
/* Figure out pin flags */
-#ifdef NOT_YET
- /* These are currently unused. */
if (gpio_res->ConnectionType == ACPI_RESOURCE_GPIO_TYPE_INT) {
switch (gpio_res->Polarity) {
case ACPI_ACTIVE_HIGH:
@@ -69,10 +67,12 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res)
break;
}
+#ifdef NOT_YET
+ /* This is not currently implemented. */
if (gpio_res->Shareable == ACPI_SHARED)
flags |= GPIO_INTR_SHAREABLE;
- }
#endif
+ }
switch (gpio_res->IoRestriction) {
case ACPI_IO_RESTRICT_INPUT:
flags |= GPIO_PIN_INPUT;