aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGleb Smirnoff <glebius@FreeBSD.org>2023-07-12 16:16:40 +0000
committerGleb Smirnoff <glebius@FreeBSD.org>2023-07-12 16:16:40 +0000
commit30f0328a322eb17e7b6bf31a8d587a071e9421ed (patch)
treeb5970e509b414c25de842c1934f5f0507497191b
parentdad11f990e2b84b55c440a42c42040f6f0821027 (diff)
downloadsrc-30f0328a322eb17e7b6bf31a8d587a071e9421ed.tar.gz
src-30f0328a322eb17e7b6bf31a8d587a071e9421ed.zip
vmm: don't return random error from vcpu_lock_all() if vcpu is empty
When vcpu array is empty, function would return random value from stack. What I observed was -1. Reviewed by: corvink, markj Differential Revision: https://reviews.freebsd.org/D40980
-rw-r--r--sys/amd64/vmm/vmm_dev.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sys/amd64/vmm/vmm_dev.c b/sys/amd64/vmm/vmm_dev.c
index f9fcb32d8e28..74c751d7f116 100644
--- a/sys/amd64/vmm/vmm_dev.c
+++ b/sys/amd64/vmm/vmm_dev.c
@@ -187,6 +187,7 @@ vcpu_lock_all(struct vmmdev_softc *sc)
int error;
uint16_t i, j, maxcpus;
+ error = 0;
vm_slock_vcpus(sc->vm);
maxcpus = vm_get_maxcpus(sc->vm);
for (i = 0; i < maxcpus; i++) {