aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKristof Provost <kp@FreeBSD.org>2024-09-06 14:47:27 +0000
committerKristof Provost <kp@FreeBSD.org>2024-09-08 17:56:20 +0000
commit550133f1d48882418d4ef6205020b8e06cfd23ec (patch)
tree846ce8dc2276266bd719968a8dcc383e738a9957
parenta05decec2d194821f8bf5c8f2ae72063de0c87a8 (diff)
pf: ensure we exit net_epoch if pf_keth_anchor_nvcopyout() fails
Reviewed by: markj Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D46599
-rw-r--r--sys/netpfil/pf/pf_ioctl.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c
index 64086bf08871..8d18da6cf0db 100644
--- a/sys/netpfil/pf/pf_ioctl.c
+++ b/sys/netpfil/pf/pf_ioctl.c
@@ -2951,8 +2951,10 @@ DIOCGETETHRULES_error:
NET_EPOCH_ENTER(et);
PF_RULES_RUNLOCK();
nvl = pf_keth_rule_to_nveth_rule(rule);
- if (pf_keth_anchor_nvcopyout(rs, rule, nvl))
+ if (pf_keth_anchor_nvcopyout(rs, rule, nvl)) {
+ NET_EPOCH_EXIT(et);
ERROUT(EBUSY);
+ }
NET_EPOCH_EXIT(et);
if (nvl == NULL)
ERROUT(ENOMEM);