diff options
| author | Warner Losh <imp@FreeBSD.org> | 2023-08-07 22:36:25 +0000 |
|---|---|---|
| committer | Warner Losh <imp@FreeBSD.org> | 2023-08-07 22:44:31 +0000 |
| commit | 63b0c00eb043cf8cfabeb63528eda3190608a805 (patch) | |
| tree | a13dfe754a2910bf82098fbff9f03aa9be47b6f4 | |
| parent | 95cd10f13971ef2f035f07c9bda14fb094edc0b3 (diff) | |
nvme: Update comment
Fix comment to note we should grab additional data from the error log
page, but don't currently (it's inclear if we should do that here
and other places in nvd that want it, or if we should let nvd / the
nda periph make the request).
Sponsored by: Netflix
Reviewed by: chuck, mav, jhb
Differential Revision: https://reviews.freebsd.org/D41315
| -rw-r--r-- | sys/dev/nvme/nvme_sim.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sys/dev/nvme/nvme_sim.c b/sys/dev/nvme/nvme_sim.c index ad6783adf181..7478f70013e6 100644 --- a/sys/dev/nvme/nvme_sim.c +++ b/sys/dev/nvme/nvme_sim.c @@ -69,7 +69,9 @@ nvme_sim_nvmeio_done(void *ccb_arg, const struct nvme_completion *cpl) /* * Let the periph know the completion, and let it sort out what - * it means. Make our best guess, though for the status code. + * it means. Report an error or success based on SC and SCT. + * We do not try to fetch additional data from the error log, + * though maybe we should in the future. */ memcpy(&ccb->nvmeio.cpl, cpl, sizeof(*cpl)); ccb->ccb_h.status &= ~CAM_SIM_QUEUED; |