diff options
| author | Ed Maste <emaste@FreeBSD.org> | 2022-01-28 22:15:02 +0000 |
|---|---|---|
| committer | Ed Maste <emaste@FreeBSD.org> | 2022-02-05 16:26:14 +0000 |
| commit | 647d3bf17cd907ded624dccf4fe4567924c4f399 (patch) | |
| tree | dcde81a455a6c703319bd1468ec47aad00b8bb82 | |
| parent | 4fa8cb965e73421df00ac5c724aa27b8a117fc32 (diff) | |
| download | src-647d3bf17cd907ded624dccf4fe4567924c4f399.tar.gz src-647d3bf17cd907ded624dccf4fe4567924c4f399.zip | |
dma: exit if invoked with invalid (zero) argc
This was prompted by the recent pkexec vulnerability (CVE-2021-4034).
This change is being made on general principle for setuid/setgid
binaries and is not in response to an actual issue.
Reviewed by: kevans, markj (both earlier)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D34087
(cherry picked from commit 1c91aedf25bce879a8aced6439200e46601eb8a4)
| -rw-r--r-- | contrib/dma/dma.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/contrib/dma/dma.c b/contrib/dma/dma.c index 72115ae2b55e..7cad25a214ee 100644 --- a/contrib/dma/dma.c +++ b/contrib/dma/dma.c @@ -428,6 +428,9 @@ main(int argc, char **argv) int nodot = 0, showq = 0, queue_only = 0, newaliases = 0; int recp_from_header = 0; + if (argc == 0) + errx(EX_OSERR, "invalid argc"); + set_username(); /* |