aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Johnston <markj@FreeBSD.org>2026-02-12 22:10:36 +0000
committerMark Johnston <markj@FreeBSD.org>2026-07-27 17:29:04 +0000
commit698e0c419895da2d0d12c5f4d61d85a1d91b6b9d (patch)
tree66807c32b78d569aa5f3032e6988bbaf09fe7fe6
parentbde29083d0590bd55d0726405a81169109b1265e (diff)
zvol: Fix uses of uninitialized variables in zvol_rename_minors_impl()
Reported-by: GitHub Copilot Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Mark Johnston <markj@FreeBSD.org> Closes #18191 (cherry picked from commit 943a05528494b2f4585541089606796476fb229e)
-rw-r--r--sys/contrib/openzfs/module/zfs/zvol.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/sys/contrib/openzfs/module/zfs/zvol.c b/sys/contrib/openzfs/module/zfs/zvol.c
index 67ba68aca83d..e1fe3eae2f27 100644
--- a/sys/contrib/openzfs/module/zfs/zvol.c
+++ b/sys/contrib/openzfs/module/zfs/zvol.c
@@ -1778,6 +1778,7 @@ zvol_rename_minors_impl(zvol_task_t *task)
if (zvol_inhibit_dev)
return;
+ last_error = 0;
oldnamelen = strlen(oldname);
rw_enter(&zvol_state_lock, RW_WRITER);
@@ -1797,6 +1798,8 @@ zvol_rename_minors_impl(zvol_task_t *task)
zv->zv_name + oldnamelen + 1);
error = zvol_os_rename_minor(zv, name);
kmem_strfree(name);
+ } else {
+ error = 0;
}
if (error) {
last_error = error;