diff options
author | Konstantin Belousov <kib@FreeBSD.org> | 2017-11-04 10:52:58 +0000 |
---|---|---|
committer | Konstantin Belousov <kib@FreeBSD.org> | 2017-11-04 10:52:58 +0000 |
commit | 6a96a39c77491f7dd40eb42db04475616a562779 (patch) | |
tree | 552af760b0d015c106cf78521485ee319f9a9689 | |
parent | 5b9a3721e6eacf404b59424db734c63f12177d8d (diff) | |
download | src-6a96a39c77491f7dd40eb42db04475616a562779.tar.gz src-6a96a39c77491f7dd40eb42db04475616a562779.zip |
C++17 requires quick_exit(3) to be async-signal safe.
Make it safe, and update man page with the useful information.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Notes
Notes:
svn path=/head/; revision=325389
-rw-r--r-- | lib/libc/stdlib/quick_exit.3 | 13 | ||||
-rw-r--r-- | lib/libc/stdlib/quick_exit.c | 7 |
2 files changed, 18 insertions, 2 deletions
diff --git a/lib/libc/stdlib/quick_exit.3 b/lib/libc/stdlib/quick_exit.3 index fb1e346bb106..9d316c7e46ea 100644 --- a/lib/libc/stdlib/quick_exit.3 +++ b/lib/libc/stdlib/quick_exit.3 @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd December 13, 2014 +.Dd November 4, 2017 .Dt QUICK_EXIT 3 .Os .Sh NAME @@ -44,6 +44,17 @@ with .Xr at_quick_exit 3 but not any C++ destructors or cleanup code registered with .Xr atexit 3 . +The +.Xr stdio 3 +file buffers are not flushed. +.Pp +The function +.Fn quick_exit +is +.Em async-signal safe +when the functions registered with +.Xr at_quick_exit 3 +are. .Sh RETURN VALUES The .Fn quick_exit diff --git a/lib/libc/stdlib/quick_exit.c b/lib/libc/stdlib/quick_exit.c index ef8cdb1b401a..4d81a35f5375 100644 --- a/lib/libc/stdlib/quick_exit.c +++ b/lib/libc/stdlib/quick_exit.c @@ -26,6 +26,8 @@ * $FreeBSD$ */ +#include <sys/types.h> +#include <machine/atomic.h> #include <stdlib.h> #include <pthread.h> @@ -60,6 +62,7 @@ at_quick_exit(void (*func)(void)) h->cleanup = func; pthread_mutex_lock(&atexit_mutex); h->next = handlers; + __compiler_membar(); handlers = h; pthread_mutex_unlock(&atexit_mutex); return (0); @@ -74,7 +77,9 @@ quick_exit(int status) * XXX: The C++ spec requires us to call std::terminate if there is an * exception here. */ - for (h = handlers; NULL != h; h = h->next) + for (h = handlers; NULL != h; h = h->next) { + __compiler_membar(); h->cleanup(); + } _Exit(status); } |