aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKristof Provost <kp@FreeBSD.org>2024-10-14 12:57:49 +0000
committerKristof Provost <kp@FreeBSD.org>2024-10-14 15:54:49 +0000
commit6b8096fa5f6f81e2959cbb2ca857c4e134273da2 (patch)
tree7fabd9e88759313c7acb9daf773bf7e52726dd00
parent1b0e41ddffbf0ac84c88019df84dfd50ce9f7788 (diff)
netpfil tests: skip checksum verification in pft_ping.py
From scapy 2.6.0 it now removes (sets to None) the IP checksum in its defrag code. We typically ask for IPv4 or IPv6 defragmentation, which causes check function failures. Just skip the checksum verificiation here, because we're going to notice incorrect checksums even if the tests don't directly verify it. MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate")
-rw-r--r--tests/sys/netpfil/common/pft_ping.py6
1 files changed, 0 insertions, 6 deletions
diff --git a/tests/sys/netpfil/common/pft_ping.py b/tests/sys/netpfil/common/pft_ping.py
index 1caa26abe5f6..0d1134a22dda 100644
--- a/tests/sys/netpfil/common/pft_ping.py
+++ b/tests/sys/netpfil/common/pft_ping.py
@@ -205,12 +205,6 @@ def check_ipv4(expect_params, packet):
if dst_address and ip.dst != dst_address:
LOGGER.debug(f'Wrong IPv4 destination {ip.dst}, expected {dst_address}')
return False
- chksum = ip.chksum
- ip.chksum = None
- new_chksum = sp.IP(sp.raw(ip)).chksum
- if chksum != new_chksum:
- LOGGER.debug(f'Wrong IPv4 checksum {chksum}, expected {new_chksum}')
- return False
if flags and ip.flags != flags:
LOGGER.debug(f'Wrong IP flags value {ip.flags}, expected {flags}')
return False