diff options
| author | наб <nabijaczleweli@nabijaczleweli.xyz> | 2021-04-07 13:27:55 +0000 |
|---|---|---|
| committer | Brian Behlendorf <behlendorf1@llnl.gov> | 2021-04-11 22:25:39 +0000 |
| commit | 88bf37d91a12d0048c24fdfb6db7b4de91377479 (patch) | |
| tree | 72b9dec15ae2f24c147b79b085434e568a33fb31 | |
| parent | d622f16b6bb183dcad97ad8848f64ebb34942102 (diff) | |
| download | src-88bf37d91a12d0048c24fdfb6db7b4de91377479.tar.gz src-88bf37d91a12d0048c24fdfb6db7b4de91377479.zip | |
zed: _zed_conf_display_help(): be consistent about what got_err means
Users passed in EXIT_SUCCESS and EXIT_FAILURE, despite it being a bool
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #11860
| -rw-r--r-- | cmd/zed/zed_conf.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/cmd/zed/zed_conf.c b/cmd/zed/zed_conf.c index cfbbe11ebba4..783e1dfd7390 100644 --- a/cmd/zed/zed_conf.c +++ b/cmd/zed/zed_conf.c @@ -126,7 +126,7 @@ zed_conf_destroy(struct zed_conf *zcp) * otherwise, output to stderr and exit with a failure status. */ static void -_zed_conf_display_help(const char *prog, int got_err) +_zed_conf_display_help(const char *prog, boolean_t got_err) { struct opt { const char *o, *d, *v; }; @@ -257,7 +257,7 @@ zed_conf_parse_opts(struct zed_conf *zcp, int argc, char **argv) while ((opt = getopt(argc, argv, opts)) != -1) { switch (opt) { case 'h': - _zed_conf_display_help(argv[0], EXIT_SUCCESS); + _zed_conf_display_help(argv[0], B_FALSE); break; case 'L': _zed_conf_display_license(); @@ -309,11 +309,11 @@ zed_conf_parse_opts(struct zed_conf *zcp, int argc, char **argv) case '?': default: if (optopt == '?') - _zed_conf_display_help(argv[0], EXIT_SUCCESS); + _zed_conf_display_help(argv[0], B_FALSE); fprintf(stderr, "%s: Invalid option '-%c'\n\n", argv[0], optopt); - _zed_conf_display_help(argv[0], EXIT_FAILURE); + _zed_conf_display_help(argv[0], B_TRUE); break; } } |