diff options
| author | Hans Petter Selasky <hselasky@FreeBSD.org> | 2017-03-23 16:23:55 +0000 |
|---|---|---|
| committer | Hans Petter Selasky <hselasky@FreeBSD.org> | 2017-03-23 16:23:55 +0000 |
| commit | 8f7eee5a63f1d5a1844fb1b08cf295b309cd0ccf (patch) | |
| tree | 6588f936654348a9e39747fac2a79c99fdb5e09b | |
| parent | d2f312e0e7590f31086f259a183eb339b42315e2 (diff) | |
Use ppsratecheck() for ratelimiting in the LinuxKPI.
Suggested by: cem @
MFC after: 1 week
Sponsored by: Mellanox Technologies
Notes
svn path=/head/; revision=315864
| -rw-r--r-- | sys/compat/linuxkpi/common/include/linux/device.h | 4 | ||||
| -rw-r--r-- | sys/compat/linuxkpi/common/include/linux/kernel.h | 14 | ||||
| -rw-r--r-- | sys/compat/linuxkpi/common/src/linux_compat.c | 14 |
3 files changed, 14 insertions, 18 deletions
diff --git a/sys/compat/linuxkpi/common/include/linux/device.h b/sys/compat/linuxkpi/common/include/linux/device.h index fbd8834629ae..d85282af4c14 100644 --- a/sys/compat/linuxkpi/common/include/linux/device.h +++ b/sys/compat/linuxkpi/common/include/linux/device.h @@ -145,13 +145,13 @@ show_class_attr_string(struct class *class, device_printf((dev)->bsddev, fmt, ##__VA_ARGS__) #define dev_err_ratelimited(dev, ...) do { \ - static time_t __ratelimited; \ + static linux_ratelimit_t __ratelimited; \ if (linux_ratelimited(&__ratelimited)) \ dev_err(dev, __VA_ARGS__); \ } while (0) #define dev_warn_ratelimited(dev, ...) do { \ - static time_t __ratelimited; \ + static linux_ratelimit_t __ratelimited; \ if (linux_ratelimited(&__ratelimited)) \ dev_warn(dev, __VA_ARGS__); \ } while (0) diff --git a/sys/compat/linuxkpi/common/include/linux/kernel.h b/sys/compat/linuxkpi/common/include/linux/kernel.h index 3b7a83f88f07..d4999e820058 100644 --- a/sys/compat/linuxkpi/common/include/linux/kernel.h +++ b/sys/compat/linuxkpi/common/include/linux/kernel.h @@ -41,6 +41,7 @@ #include <sys/smp.h> #include <sys/stddef.h> #include <sys/syslog.h> +#include <sys/time.h> #include <linux/bitops.h> #include <linux/compiler.h> @@ -225,7 +226,7 @@ scnprintf(char *buf, size_t size, const char *fmt, ...) #define pr_cont(fmt, ...) \ printk(KERN_CONT fmt, ##__VA_ARGS__) #define pr_warn_ratelimited(...) do { \ - static time_t __ratelimited; \ + static linux_ratelimit_t __ratelimited; \ if (linux_ratelimited(&__ratelimited)) \ pr_warning(__VA_ARGS__); \ } while (0) @@ -423,6 +424,15 @@ abs64(int64_t x) return (x < 0 ? -x : x); } -extern bool linux_ratelimited(time_t *); +typedef struct linux_ratelimit { + struct timeval lasttime; + int counter; +} linux_ratelimit_t; + +static inline bool +linux_ratelimited(linux_ratelimit_t *rl) +{ + return (ppsratecheck(&rl->lasttime, &rl->counter, 1)); +} #endif /* _LINUX_KERNEL_H_ */ diff --git a/sys/compat/linuxkpi/common/src/linux_compat.c b/sys/compat/linuxkpi/common/src/linux_compat.c index 62682f087665..37f607cf8861 100644 --- a/sys/compat/linuxkpi/common/src/linux_compat.c +++ b/sys/compat/linuxkpi/common/src/linux_compat.c @@ -1484,20 +1484,6 @@ __unregister_chrdev(unsigned int major, unsigned int baseminor, bool linux_cpu_has_clflush; #endif -bool -linux_ratelimited(time_t *ptime) -{ - /* make sure uptime is not zero by OR'ing bit 31 */ - time_t curr = time_uptime | (1U << 31); - - /* check if one or more seconds have passed */ - if (*ptime != curr) { - *ptime = curr; - return (1); - } - return (0); -} - static void linux_compat_init(void *arg) { |
