aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKristof Provost <kp@FreeBSD.org>2026-03-12 14:24:42 +0000
committerPhilip Paeps <philip@FreeBSD.org>2026-03-25 16:13:37 +0000
commit926ee630b73d5bf0264bf69284ef4a407b2462d4 (patch)
tree036464356eead62d482bd9221535ff1632390788
parent89ab511c1ce2a979b5d0e7fdbb3289442b35d8a3 (diff)
pfctl: always warn if a duplicate rule was detected
Approved by: so Security: FreeBSD-SA-26:09.pf Security: CVE-2026-4748 Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 66d66dd0f6f83926980fc1d68dd366c0057350c5) (cherry picked from commit e79818ec36efafc994d8c5a912dcb94986c038c5)
-rw-r--r--sbin/pfctl/pfctl.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sbin/pfctl/pfctl.c b/sbin/pfctl/pfctl.c
index d6bb0ae7f46f..518b32085565 100644
--- a/sbin/pfctl/pfctl.c
+++ b/sbin/pfctl/pfctl.c
@@ -2043,13 +2043,13 @@ pfctl_load_rule(struct pfctl *pf, char *path, struct pfctl_rule *r, int depth)
}
}
- if (pf->opts & PF_OPT_VERBOSE) {
+ if (pf->opts & PF_OPT_VERBOSE || was_present) {
INDENT(depth, !(pf->opts & PF_OPT_VERBOSE2));
print_rule(r, name,
pf->opts & PF_OPT_VERBOSE2,
pf->opts & PF_OPT_NUMERIC);
if (was_present)
- printf(" -- rule was already present");
+ printf(" -- rule was already present\n");
}
path[len] = '\0';
pfctl_clear_pool(&r->rpool);