aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyle Evans <kevans@FreeBSD.org>2023-06-23 16:41:07 +0000
committerKyle Evans <kevans@FreeBSD.org>2023-07-11 15:05:38 +0000
commitea2a3ed3bcf7e792ba0c0625602ada29424c337c (patch)
tree386e20064dccb60f7e52924dfd2a8f35f8509a60
parent679ff7a0c58a64ca5d11e235b7ba74fdebc3bc37 (diff)
wg: fix MOD_LOAD to fail properly if cookie_init() fails
Previously we'd jump to the `free_crypto` label, but never set `ret` to a failure value -- it would retain success from the call just prior. Set ret up properly. (cherry picked from commit ad9f4e6351fb23ee81bc940638d20af3ca7c278d)
-rw-r--r--sys/dev/wg/if_wg.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sys/dev/wg/if_wg.c b/sys/dev/wg/if_wg.c
index 9c4ebe5dd393..8ba1d229da4f 100644
--- a/sys/dev/wg/if_wg.c
+++ b/sys/dev/wg/if_wg.c
@@ -2998,7 +2998,8 @@ wg_module_init(void)
ret = crypto_init();
if (ret != 0)
goto free_zone;
- if (cookie_init() != 0)
+ ret = cookie_init();
+ if (ret != 0)
goto free_crypto;
wg_osd_jail_slot = osd_jail_register(NULL, methods);