aboutsummaryrefslogtreecommitdiff
path: root/bin/ls/print.c
diff options
context:
space:
mode:
authorTim J. Robbins <tjr@FreeBSD.org>2002-12-19 01:13:23 +0000
committerTim J. Robbins <tjr@FreeBSD.org>2002-12-19 01:13:23 +0000
commit3fceb9fd5bbd9de85a6cf1bd7863aa89e938e274 (patch)
treea7bcf931da461f61ac1339a7d05fb8624cecaa21 /bin/ls/print.c
parent71ffa67746aec9c5da566ff4d48c0f807db6834a (diff)
downloadsrc-3fceb9fd5bbd9de85a6cf1bd7863aa89e938e274.tar.gz
src-3fceb9fd5bbd9de85a6cf1bd7863aa89e938e274.zip
pathconf() and acl_get_file() follow links so they cannot be used to
determine whether a symlink has an ACL. Instead, assume that symbolic links don't have ACLs and don't bother checking. Avoids spurious ENOENT warnings when listing directories containing broken symlinks on filesystems with ACLs enabled. Pointed out by: rwatson, bde
Notes
Notes: svn path=/head/; revision=108066
Diffstat (limited to 'bin/ls/print.c')
-rw-r--r--bin/ls/print.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/bin/ls/print.c b/bin/ls/print.c
index 841270bbb2e9..2fab63a37de5 100644
--- a/bin/ls/print.c
+++ b/bin/ls/print.c
@@ -674,6 +674,14 @@ aclmode(char *buf, FTSENT *p, int *haveacls)
else
snprintf(name, sizeof(name), "%s/%s",
p->fts_parent->fts_accpath, p->fts_name);
+ /*
+ * We have no way to tell whether a symbolic link has an ACL since
+ * pathconf() and acl_get_file() both follow them.
+ */
+ if (S_ISLNK(p->fts_statp->st_mode)) {
+ *haveacls = 1;
+ return;
+ }
if ((ret = pathconf(name, _PC_ACL_EXTENDED)) <= 0) {
if (ret < 0 && errno != EINVAL)
warn("%s", name);