aboutsummaryrefslogtreecommitdiff
path: root/bin/pkill/pkill.c
diff options
context:
space:
mode:
authorAndriy Gapon <avg@FreeBSD.org>2017-10-27 12:37:22 +0000
committerAndriy Gapon <avg@FreeBSD.org>2017-10-27 12:37:22 +0000
commit1c05a6ea6b849ff95e539c31adea887c644a6a01 (patch)
treeea98df37378493867ac7345be55a9841f48b3f77 /bin/pkill/pkill.c
parente223d957c3be7cd41c2c8e143e2543a0d45259d2 (diff)
parentae99a88d67d0b4329f0bc3d0ff1041e6b2c8c57d (diff)
downloadsrc-1c05a6ea6b849ff95e539c31adea887c644a6a01.tar.gz
src-1c05a6ea6b849ff95e539c31adea887c644a6a01.zip
MFV r325013,r325034: 640 number_to_scaled_string is duplicated in several commands
illumos/illumos-gate@0a0551200ecbcd4f1b17560acaeeb7b6c8b0090e https://github.com/illumos/illumos-gate/commit/0a0551200ecbcd4f1b17560acaeeb7b6c8b0090e https://www.illumos.org/issues/640 du(1), df(1m), ls(1), and swap(1m) all include a copy (it appears literally copied) of the 'number_to_scaled_string' function in their source. This should be moved to a shared library and all 4 commands should use this instead. FreeBSD note: of all libcmdutils functionality ZFS (and other illumos contrib code) currently uses only nicenum() function (which is similar to humanize_number but has some formatting differences). For this reason I decided to not port the whole library. As a result, nicenum.c from libcmdutils is compiled into libzfs and libzpool. This is a bit ugly, but works. If one day we are forced to create libillumos, then the file should be moved to that library. Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net> Reviewed by: Robert Mustacchi <rm@joyent.com> Reviewed by: Yuri Pankov <yuripv@gmx.com> Approved by: Dan McDonald <danmcd@joyent.com> Author: Jason King <jason.brian.king@gmail.com> MFC after: 2 weeks
Notes
Notes: svn path=/head/; revision=325035
Diffstat (limited to 'bin/pkill/pkill.c')
0 files changed, 0 insertions, 0 deletions