Merge bmake-20210110

Quite a lot of churn on style, but lots of
good work refactoring complicated functions
and lots more unit-tests.
Thanks mostly to rillig at NetBSD

Some interesting entries from ChangeLog

o .MAKE.{UID,GID} represent uid and gid running make.

o allow env var MAKE_OBJDIR_CHECK_WRITABLE=no to skip writable
  checks in InitObjdir.  Explicit .OBJDIR target always allows
  read-only directory.

o add more unit tests for META MODE

Merge commit '8e11a9b4250be3c3379c45fa820bff78d99d5946' into main

Change-Id: I464fd4c013067f0915671c1ccc96d2d8090b2b9c

1 files changed, 6 insertions, 3 deletions

diff --git a/contrib/bmake/unit-tests/suff-transform-endless.mk b/contrib/bmake/unit-tests/suff-transform-endless.mk
index 546e24f398ad..d3b1cf24d8aa 100644
--- a/contrib/bmake/unit-tests/suff-transform-endless.mk
+++ b/contrib/bmake/unit-tests/suff-transform-endless.mk
@@ -1,4 +1,4 @@
-# $NetBSD: suff-transform-endless.mk,v 1.1 2020/10/20 20:36:53 rillig Exp $
+# $NetBSD: suff-transform-endless.mk,v 1.4 2020/11/23 14:47:12 rillig Exp $
 
 # https://gnats.netbsd.org/49086, issue 6:
 # Transformation search can end up in an infinite loop.
@@ -8,6 +8,8 @@
 # exist, make would try to make .f from .e and then infinitely try
 # to do .e from .d and vice versa.
 
+.MAKEFLAGS: -ds
+
 all: issue6.f
 
 .c.d .d.c .d .d.e .e.d:
@@ -16,7 +18,7 @@ all: issue6.f
 .SUFFIXES: .c .d .e .f
 
 .e .e.f .f.e:
-	: 'Making ${.TARGET} out of nothing.'
+	: 'Making ${.TARGET} from ${.IMPSRC}.'
 
 # XXX: As of 2020-10-20, the result is unexpected.
 # XXX: .d.c is not a transformation rule.
@@ -33,4 +35,5 @@ all: issue6.f
 # XXX: Found 'all' as '(not found)'
 # XXX: trying all.e, all.e, all.f, all.e, all.e, repeatedly.
 #.MAKEFLAGS: -dg1
-.error prevent endless loop
+
+# Before 24-11-2020, resolving all.e ran into an endless loop.