diff options
author | Colin Percival <cperciva@FreeBSD.org> | 2025-10-07 20:48:06 +0000 |
---|---|---|
committer | Colin Percival <cperciva@FreeBSD.org> | 2025-10-08 04:42:10 +0000 |
commit | b6f69c39999bfb85af262363b4fe22edc80027d7 (patch) | |
tree | fe51e47e74a55656d53be3c2cce99397032b5c5e /contrib/unbound/cachedb/redis.c | |
parent | a6ac2c98c9cb22a4a2efc12cafce2d2ba82b3fdc (diff) |
The 'make release' command triggers some sub-builds, in particular
'real-release' (which builds install images) and 'vm-release' (which
builds VM images). These both now depend on pkgbase-repo.
Unfortunately for historical reasons 'make real-release' has used a
recursive make instead of proper make dependencies; this results in
the pkgbase-repo target being invoked twice since the recursive make
does not have any awareness of the targets being run by the parent
make command. Since the pkgbase-repo target starts by creating the
pkgbase-repo directory, the second make command incorrectly assumes
that target has already been built; this showed up in 15.0-ALPHA5
builds with pkgbase-repo.tar being empty as it was created after the
pkgbase-repo directory was created by before that directory had been
populated.
Change
real-release:
make obj
make ${RELEASE_TARGETS}
to a single line
real-release: obj .WAIT ${RELEASE_TARGETS}
in order to handle dependency deduplication properly while keeping
the intended behaviour that "obj" completes before ${RELEASE_TARGETS}.
Diagnosed by: jrtc27, emaste
Reviewed by: emaste
MFC after: 1 day
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52972
Diffstat (limited to 'contrib/unbound/cachedb/redis.c')
0 files changed, 0 insertions, 0 deletions