diff options
author | Alan Somers <asomers@FreeBSD.org> | 2019-05-21 15:59:17 +0000 |
---|---|---|
committer | Alan Somers <asomers@FreeBSD.org> | 2019-05-21 15:59:17 +0000 |
commit | d5fce87d7c548230591e5a50955af6532a644715 (patch) | |
tree | c0d8af8f39ba3f0e47c3c6cfaf536ecb325dde28 /lib/libc/gen/getvfsbyname.c | |
parent | d311d6c4670fb3fcb7c00f0c3d425c4e6aeb9186 (diff) | |
download | src-d5fce87d7c548230591e5a50955af6532a644715.tar.gz src-d5fce87d7c548230591e5a50955af6532a644715.zip |
getvfsbyname: prefer sizeof to strlen even for constants
Clang is smart enough to evaluate strlen() of a constant at compile-time.
However, that won't work in the future if we compile libc with
-ffreestanding.
Reported by: kib
Dissenting: ngie, cem
Sponsored by: The FreeBSD Foundation
Notes
Notes:
svn path=/projects/fuse2/; revision=348054
Diffstat (limited to 'lib/libc/gen/getvfsbyname.c')
-rw-r--r-- | lib/libc/gen/getvfsbyname.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/libc/gen/getvfsbyname.c b/lib/libc/gen/getvfsbyname.c index 4a1202aff5ad..7d338631a087 100644 --- a/lib/libc/gen/getvfsbyname.c +++ b/lib/libc/gen/getvfsbyname.c @@ -49,10 +49,11 @@ __FBSDID("$FreeBSD$"); static bool are_fusefs(const char *fsname, const char *vfc_name) { - const char fusefs[] = "fusefs"; - const char fusefs_dot[] = "fusefs."; + const static char fusefs[] = "fusefs"; + const static char fusefs_dot[] = "fusefs."; - return (strncmp(fsname, fusefs_dot, strlen(fusefs_dot)) == 0 && + + return (strncmp(fsname, fusefs_dot, sizeof(fusefs_dot) - 1) == 0 && strcmp(fusefs, vfc_name) == 0); } |