diff options
| author | Dag-Erling Smørgrav <des@FreeBSD.org> | 2026-04-30 16:45:35 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2026-04-30 21:21:45 +0000 |
| commit | dfcb69cdb07edcee90af4ce4fa11207655c5424e (patch) | |
| tree | 319a85c798f60842414e25bbade6b7edb3bf06d7 /lib/libdevstat/devstat.3 | |
| parent | d7784de043f1543a1575e9fae8cd56a4fd7c776d (diff) | |
dhclient: Improve server and filename validation
* Don't iterate over each string three times; once is enough.
* Reject control characters (anything below space) in addition to the
double quote and backslash.
* If an unsafe character is encountered, discard the string instead of
rejecting the entire lease.
* If backslashes are encountered in the file name option, convert them
to forward slashes instead of rejecting the option.
* Tweak the warning messages a bit. Looking through the rest of the
code, it seems to me that notes generally end with a period while
warnings generally don't.
Approved by: so
Security: FreeBSD-EN-26:11.dhclient
Fixes: 8008e4b88daf ("dhclient: Check for unexpected characters in some DHCP server options")
PR: 294886
MFC after: 1 week
Reviewed by: brooks, markj
Differential Revision: https://reviews.freebsd.org/D56740
(cherry picked from commit 873a195ba63575e46686cfd6ea9670a0ca340fa0)
(cherry picked from commit 2f9478ad42c442c49a7eff60227148bf2b90b48c)
Diffstat (limited to 'lib/libdevstat/devstat.3')
0 files changed, 0 insertions, 0 deletions