diff options
| author | Abdelkader Boudih <oss@seuros.com> | 2026-01-03 18:33:11 +0000 |
|---|---|---|
| committer | Adrian Chadd <adrian@FreeBSD.org> | 2026-01-03 18:35:53 +0000 |
| commit | 2a7c4685b7693bfa15e2bd4d5e82905a368b0030 (patch) | |
| tree | c9372c4f70f630113aec21928a79c13ed9dfcdef /release/picobsd/bridge/(public-mirror) | |
| parent | 8ac77ea6a3c6ce99d39e1dd4e19adb444b2b4d5a (diff) | |
The asmc_dumpall debug function previously used a hardcoded loop limit
of 0x100 (256) keys with a "XXX magic number" comment.
This change improves asmc_dumpall to:
* Read the actual number of keys from the ASMC_NKEYS SMC key
* Print the key count being dumped for better debugging output
* Loop only up to the actual key count (e.g., 297 on Mac Mini 5,1)
This provides more accurate debug output and removes the magic number.
Tested on Mac Mini 5,1 (FreeBSD 16.0-CURRENT):
* Rebuild kernel with DEBUG enabled in asmc driver
* Boot with new kernel
* Verify dmesg shows "asmc_dumpall: dumping 297 keys" (or actual count)
* Verify all 297 keys are dumped
Differential Revision: https://reviews.freebsd.org/D54436
Reviewed by: markj, adrian
Diffstat (limited to 'release/picobsd/bridge/(public-mirror)')
0 files changed, 0 insertions, 0 deletions
