diff options
| author | Dag-Erling Smørgrav <des@FreeBSD.org> | 2026-04-30 16:45:35 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2026-04-30 21:09:38 +0000 |
| commit | dc8762cfb6e2794ec10873263fa606ff969b1905 (patch) | |
| tree | 3486e107f626b389e5b8d1329b32729b8377b6d3 /release | |
| parent | bbfdabc12895ce2538444747684c6a4fe53298ba (diff) | |
dhclient: Improve server and filename validation
* Don't iterate over each string three times; once is enough.
* Reject control characters (anything below space) in addition to the
double quote and backslash.
* If an unsafe character is encountered, discard the string instead of
rejecting the entire lease.
* If backslashes are encountered in the file name option, convert them
to forward slashes instead of rejecting the option.
* Tweak the warning messages a bit. Looking through the rest of the
code, it seems to me that notes generally end with a period while
warnings generally don't.
Approved by: so
Security: FreeBSD-EN-26:11.dhclient
Fixes: 8008e4b88daf ("dhclient: Check for unexpected characters in some DHCP server options")
PR: 294886
MFC after: 1 week
Reviewed by: brooks, markj
Differential Revision: https://reviews.freebsd.org/D56740
(cherry picked from commit 873a195ba63575e46686cfd6ea9670a0ca340fa0)
(cherry picked from commit 252f603d1704044defb7695e707bc87c7f75483a)
Diffstat (limited to 'release')
0 files changed, 0 insertions, 0 deletions