diff options
| author | Eitan Adler <eadler@FreeBSD.org> | 2018-02-15 03:22:53 +0000 |
|---|---|---|
| committer | Eitan Adler <eadler@FreeBSD.org> | 2018-02-15 03:22:53 +0000 |
| commit | dacbef689d3fb076f8e4f565dff0ca1e34d74ce1 (patch) | |
| tree | 936c5a491e9bb63764417764d7d171fd265a8812 /sbin/devd/devd.cc | |
| parent | c756fb6ebbdac854916fb08524d68d871f1f888c (diff) | |
| download | src-dacbef689d3fb076f8e4f565dff0ca1e34d74ce1.tar.gz src-dacbef689d3fb076f8e4f565dff0ca1e34d74ce1.zip | |
devd: don't pass &fds in useless parameters to select(2)
select(2) should be declared as restrict. In addition the only fd in
the fdset is open O_RDONLY, and it's not a socket that can provide OOB
notifications,
Reviewed by: ian, imp, vangyzen
Notes
Notes:
svn path=/head/; revision=329296
Diffstat (limited to 'sbin/devd/devd.cc')
| -rw-r--r-- | sbin/devd/devd.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sbin/devd/devd.cc b/sbin/devd/devd.cc index f3111412fd17..51653e2f8596 100644 --- a/sbin/devd/devd.cc +++ b/sbin/devd/devd.cc @@ -1021,7 +1021,7 @@ event_loop(void) tv.tv_usec = 0; FD_ZERO(&fds); FD_SET(fd, &fds); - rv = select(fd + 1, &fds, &fds, &fds, &tv); + rv = select(fd + 1, &fds, NULL, NULL, &tv); // No events -> we've processed all pending events if (rv == 0) { devdlog(LOG_DEBUG, "Calling daemon\n"); |