In hast.conf we define the other node's address in 'remote' variable.

This way we know how to connect to secondary node when we are primary.
The same variable is used by the secondary node - it only accepts
connections from the address stored in 'remote' variable.
In cluster configurations it is common that each node has its individual
IP address and there is one addtional shared IP address which is assigned
to primary node. It seems it is possible that if the shared IP address is
from the same network as the individual IP address it might be choosen by
the kernel as a source address for connection with the secondary node.
Such connection will be rejected by secondary, as it doesn't come from
primary node individual IP.

Add 'source' variable that allows to specify source IP address we want to
bind to before connecting to the secondary node.

MFC after:	1 week

1 files changed, 4 insertions, 2 deletions

diff --git a/sbin/hastd/proto_socketpair.c b/sbin/hastd/proto_socketpair.c
index d681493a8663..74034d7d998a 100644
--- a/sbin/hastd/proto_socketpair.c
+++ b/sbin/hastd/proto_socketpair.c
@@ -57,14 +57,16 @@ struct sp_ctx {
 static void sp_close(void *ctx);
 
 static int
-sp_client(const char *addr, void **ctxp)
+sp_client(const char *srcaddr, const char *dstaddr, void **ctxp)
 {
 	struct sp_ctx *spctx;
 	int ret;
 
-	if (strcmp(addr, "socketpair://") != 0)
+	if (strcmp(dstaddr, "socketpair://") != 0)
 		return (-1);
 
+	PJDLOG_ASSERT(srcaddr == NULL);
+
 	spctx = malloc(sizeof(*spctx));
 	if (spctx == NULL)
 		return (errno);