diff options
author | Mateusz Guzik <mjg@FreeBSD.org> | 2019-12-08 21:13:07 +0000 |
---|---|---|
committer | Mateusz Guzik <mjg@FreeBSD.org> | 2019-12-08 21:13:07 +0000 |
commit | 791a24c7ea7d3ad41c703327d40e64d3ef6d02e2 (patch) | |
tree | 279bbeae4c797fde275d02b024c89cb616aa894d /sys/cam/ctl | |
parent | 35e9bfc98f56c884564e22af47385fe801831dc4 (diff) | |
download | src-791a24c7ea7d3ad41c703327d40e64d3ef6d02e2.tar.gz src-791a24c7ea7d3ad41c703327d40e64d3ef6d02e2.zip |
vfs: clean up vputx a little
1. replace hand-rolled macros for operation type with enum
2. unlock the vnode in vput itself, there is no need to branch on it. existence
of VPUTX_VPUT remains significant in that the inactive variant adds LK_NOWAIT
to locking request.
3. remove the useless v_usecount assertion. few lines above the checks if
v_usecount > 0 and leaves. should the value be negative, refcount would fail.
4. the CTR return vnode %p to the freelist is incorrect as vdrop may find the
vnode with holdcnt > 1. if the like should exist, it should be moved there
5. no need to error = 0 for everyone
Reviewed by: kib, jeff (previous version)
Differential Revision: https://reviews.freebsd.org/D22718
Notes
Notes:
svn path=/head/; revision=355536
Diffstat (limited to 'sys/cam/ctl')
0 files changed, 0 insertions, 0 deletions