diff options
| author | Mateusz Guzik <mjg@FreeBSD.org> | 2022-02-22 15:54:17 +0000 |
|---|---|---|
| committer | Mateusz Guzik <mjg@FreeBSD.org> | 2022-02-22 18:53:43 +0000 |
| commit | f17ef28674f13bc2199d4819123248f5997b435a (patch) | |
| tree | 0e73178c16634f363c4c2a372295a33f4225b1a4 /sys/cddl/contrib/opensolaris/uts | |
| parent | 0a2f498234023008d9a3b13ad7fc8fd81d384bab (diff) | |
fd: rename fget*_locked to fget*_noref
This gets rid of the error prone naming where fget_unlocked returns with
a ref held, while fget_locked requires a lock but provides nothing in
terms of making sure the file lives past unlock.
No functional changes.
Diffstat (limited to 'sys/cddl/contrib/opensolaris/uts')
| -rw-r--r-- | sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c b/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c index 38612a088066..b2e7b01b125c 100644 --- a/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c +++ b/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c @@ -5664,7 +5664,10 @@ dtrace_dif_subr(uint_t subr, uint_t rd, uint64_t *regs, } fdp = curproc->p_fd; FILEDESC_SLOCK(fdp); - fp = fget_locked(fdp, fd); + /* + * XXXMJG this looks broken as no ref is taken. + */ + fp = fget_noref(fdp, fd); mstate->dtms_getf = fp; regs[rd] = (uintptr_t)fp; FILEDESC_SUNLOCK(fdp); |