diff options
author | Paul Saab <ps@FreeBSD.org> | 2006-04-08 02:23:27 +0000 |
---|---|---|
committer | Paul Saab <ps@FreeBSD.org> | 2006-04-08 02:23:27 +0000 |
commit | 026d2aa333fe1184333eadac35e29264f083d879 (patch) | |
tree | f23c1087558ca8d21c4abd3fd664e86f7a32a62b /sys/dev/amr/amr.c | |
parent | 07c893135871fd61e10eb4ebf08eaae76c81d306 (diff) | |
download | src-026d2aa333fe1184333eadac35e29264f083d879.tar.gz src-026d2aa333fe1184333eadac35e29264f083d879.zip |
Close a pesky race where after checking the BUSY flag in amr_wait_command,
the completion of the command can occur before tsleep is called and
the command ends up blocking forever since the wakeup has already
been called.
Submitted by: ups
Notes
Notes:
svn path=/head/; revision=157585
Diffstat (limited to 'sys/dev/amr/amr.c')
-rw-r--r-- | sys/dev/amr/amr.c | 25 |
1 files changed, 19 insertions, 6 deletions
diff --git a/sys/dev/amr/amr.c b/sys/dev/amr/amr.c index c8bb39e5dac9..d7e806c30a19 100644 --- a/sys/dev/amr/amr.c +++ b/sys/dev/amr/amr.c @@ -383,6 +383,9 @@ amr_free(struct amr_softc *sc) if (mtx_initialized(&sc->amr_list_lock)) mtx_destroy(&sc->amr_list_lock); + + if (mtx_initialized(&sc->amr_wait_lock)) + mtx_destroy(&sc->amr_wait_lock); } /******************************************************************************* @@ -1322,7 +1325,8 @@ static int amr_wait_command(struct amr_command *ac) { int error = 0; - + struct amr_softc *sc = ac->ac_sc; + debug_called(1); ac->ac_complete = NULL; @@ -1331,9 +1335,12 @@ amr_wait_command(struct amr_command *ac) return(error); } + mtx_lock(&sc->amr_wait_lock); while ((ac->ac_flags & AMR_CMD_BUSY) && (error != EWOULDBLOCK)) { - error = tsleep(ac, PRIBIO, "amrwcmd", 0); + error = msleep(ac,&sc->amr_wait_lock, PRIBIO, "amrwcmd", 0); } + mtx_unlock(&sc->amr_wait_lock); + return(error); } @@ -1995,21 +2002,27 @@ amr_complete(void *context, int pending) /* unmap the command's data buffer */ amr_unmapcmd(ac); - /* unbusy the command */ - ac->ac_flags &= ~AMR_CMD_BUSY; - /* * Is there a completion handler? */ if (ac->ac_complete != NULL) { + /* unbusy the command */ + ac->ac_flags &= ~AMR_CMD_BUSY; ac->ac_complete(ac); /* * Is someone sleeping on this one? */ } else if (ac->ac_flags & AMR_CMD_SLEEP) { + mtx_lock(&sc->amr_wait_lock); + /* unbusy the command */ + ac->ac_flags &= ~AMR_CMD_BUSY; + mtx_unlock(&sc->amr_wait_lock); wakeup(ac); - } + } else { + /* unbusy the command */ + ac->ac_flags &= ~AMR_CMD_BUSY; + } if(!sc->amr_busyslots) { wakeup(sc); |